Flaky perf_unittests failure: telemetry.internal.results.json_3_output_formatter_unittest.Json3OutputFormatterTest.testIntegrationCreateJsonTestResults |
|||||
Issue description
telemetry.internal.results.json_3_output_formatter_unittest.Json3OutputFormatterTest.testIntegrationCreateJsonTestResults seems failing due to a precision problem.
json_3_output_formatter_unittest.py is trying to check like the following:
self.assertAlmostEqual(json_test_results['seconds_since_epoch'],
time.time(), 1)
but when the 2nd decimal of time.time() is larger than 5, round(json_test_results['seconds_since_epoch'] - time.time(), 1) could be -0.1.
This is a log of the failing test:
https://chromium-swarm.appspot.com/task?id=398a0144b9cb5510&refresh=10&show_raw=1
,
Oct 31 2017
,
Oct 31 2017
If a quick fix cannot be completed, please disable the test as it's causing difficulty tracking failures: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%281%29 Thanks, Chromium sheriff
,
Oct 31 2017
thanks for reporting! I'll take a look and get a quick fix out; it should be really easy but if I can't fix it in the next ~1 hour for some reason, I'll disable
,
Oct 31 2017
https://chromium-review.googlesource.com/c/catapult/+/747052 is in the CQ now
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/14715602e04a3a6e6cf79342f45d2f2595cce0f4 commit 14715602e04a3a6e6cf79342f45d2f2595cce0f4 Author: Ashley Enstad <ashleymarie@chromium.org> Date: Tue Oct 31 19:15:16 2017 Change time check to be within one second to avoid rounding flakiness BUG= chromium:779966 Change-Id: I53449da6e2d9d9a2fe94a542bda9c46bfac1bb67 Reviewed-on: https://chromium-review.googlesource.com/747052 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> [modify] https://crrev.com/14715602e04a3a6e6cf79342f45d2f2595cce0f4/telemetry/telemetry/internal/results/json_3_output_formatter_unittest.py
,
Oct 31 2017
Should be fixed now but I'll keep an eye on the Windows bot it was flaky on and mark this fixed once it's back to green
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f381a3d846157989f5fcaed77a7177b8dd45c8b1 commit f381a3d846157989f5fcaed77a7177b8dd45c8b1 Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Tue Oct 31 20:30:44 2017 Roll src/third_party/catapult/ 764d38bb9..14715602e (1 commit) https://chromium.googlesource.com/catapult.git/+log/764d38bb9584..14715602e04a $ git log 764d38bb9..14715602e --date=short --no-merges --format='%ad %ae %s' 2017-10-31 ashleymarie Change time check to be within one second to avoid rounding flakiness Created with: roll-dep src/third_party/catapult BUG= 779966 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I970d572d3e168119fce4fb2c9ead0e279ff286ba Reviewed-on: https://chromium-review.googlesource.com/747631 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#512938} [modify] https://crrev.com/f381a3d846157989f5fcaed77a7177b8dd45c8b1/DEPS
,
Nov 1 2017
Looks like it has been green since this code made it in, so I'm going to mark this one fixed Please reopen if you see similar flakes thanks :)
,
Nov 1 2017
,
Jan 16
,
Jan 16
(6 days ago)
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by shimazu@chromium.org
, Oct 31 2017