Regression:Undo toast is seen even after navigating back/forward in manage password section.
Reported by
vku...@etouch.net,
Oct 31 2017
|
|||||||
Issue descriptionChrome Version: 64.0.3253.3 (Official Build) d5f4ba12a6c29b1b49da50663e51d7d6d2dad88e-refs/branch-heads/3253@{#5} (32/64-bit) OS:Windows (7,8,10),Linux (14.04 LTS), Mac(10.12.6) What steps will reproduce the problem? (1)Launch chrome and login to https://twitter.com/ with valid credentials. (2)Click 'save' button from password bubble, click on manage password link button (3)Now click on remove button, click back navigation button and again click forward button,observe Actual: Undo toast is seen even after navigating back/forward in manage password section. Expected: Undo toast should not be seen once navigated back in manage password section. This is a regression issue broken in 'M63' and will soon update bisect info.
,
Oct 31 2017
Tagging with blocker label, please undo if not the case.
,
Oct 31 2017
Looping Reviewers since for @jdoerrie crbug is displaying OOO til Nov 13th
,
Oct 31 2017
Given the suspected CL implemented the feature, I'm not sure calling this a regression is strictly accurate. +dpapad@, mind helping to triage this?
,
Oct 31 2017
We should ensure that the toast is dismissed if the user navigates away from the passwords page, so yes I do think this is a bug, not a regression though since this is a new feature. I don't think this needs to be ReleaseBlock-Stable though, please re-add if you think otherwise.
,
Nov 2 2017
I don't think it's a terrible bug. Let's wait for Jan to return.
,
Nov 20 2017
I agree this looks like an unexpected behavior, I will send out a fix for this. However, I share dpapad@'s and vasilii@'s assessment that this is not a very critical bug. Moving down to P2.
,
Nov 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92804fa56a188b4934b93dca6467dc368f694696 commit 92804fa56a188b4934b93dca6467dc368f694696 Author: jdoerrie <jdoerrie@chromium.org> Date: Mon Nov 27 22:58:04 2017 Fix Undo Toast Behavior This change fixes the undo toast so that navigating away from the password settings page will hide it if shown. Bug: 779945 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0e10f352701c7caf356e070f2b4c6f7cd8b59b41 Reviewed-on: https://chromium-review.googlesource.com/779200 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#519438} [modify] https://crrev.com/92804fa56a188b4934b93dca6467dc368f694696/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js [modify] https://crrev.com/92804fa56a188b4934b93dca6467dc368f694696/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
,
Nov 28 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by vku...@etouch.net
, Oct 31 2017Owner: jdoerrie@chromium.org
Status: Assigned (was: Unconfirmed)