New issue
Advanced search Search tips

Issue 779943 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

shill: timeout for D-Bus proxy method calls isn't propagated correctly

Project Member Reported by benchan@chromium.org, Oct 31 2017

Issue description

The async D-Bus proxy method calls generated by chromeos-dbus-bindings has a 'timeout_ms' argument that specifies the timeout for the D-Bus call. The 'timeout_ms' argument has a default value set to dbus::ObjectProxy:TIMEOUT_USE_DEFAULT, which indicates that the default timeout (typically 25 seconds) set by D-Bus should be used.

When shill was migrated to use chromeos-dbus-bindings, a regression was introduced where the timeout values chosen for various async D-Bus proxy method calls aren't actually used. As most of these timeout values are greater than the default timeout set by D-Bus, some D-Bus calls for a long operation (e.g. cellular network scan) may time out unexpectedly.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/ac2d943e806fbc6073a51f751536b03dcdfd60a5

commit ac2d943e806fbc6073a51f751536b03dcdfd60a5
Author: Ben Chan <benchan@chromium.org>
Date: Wed Nov 01 00:31:05 2017

shill: dbus: propagate timeout to async proxy method calls

The async D-Bus proxy method calls generated by chromeos-dbus-bindings
has a 'timeout_ms' argument that specifies the timeout for the D-Bus
call. The 'timeout_ms' argument has a default value set to
dbus::ObjectProxy:TIMEOUT_USE_DEFAULT, which indicates that the default
timeout (typically 25 seconds) set by D-Bus should be used. This CL
fixes a regression, introduced when shill was migrated to use
chromeos-dbus-bindings, where the timeout values chosen for various
async D-Bus proxy method calls aren't actually used. As most of these
timeout values are greater than the default timeout set by D-Bus, some
D-Bus calls for a long operation may time out unexpectedly.

BUG= chromium:779943 
BUG=b:67077612
TEST=Tested the following:
- Run unit tests.
- Run network3g tests.
- Perform a mobile network scan from the Chrome OS settings UI and
  observe that the scan eventually completes when it takes more than
  25 seconds.

Change-Id: I45584b6cee1eab88c3e6bb4c55bd2470eed7c689
Reviewed-on: https://chromium-review.googlesource.com/745862
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/ac2d943e806fbc6073a51f751536b03dcdfd60a5/dbus/chromeos_wimax_device_proxy.cc
[modify] https://crrev.com/ac2d943e806fbc6073a51f751536b03dcdfd60a5/dbus/chromeos_modem_gsm_network_proxy.cc
[modify] https://crrev.com/ac2d943e806fbc6073a51f751536b03dcdfd60a5/dbus/chromeos_modem_cdma_proxy.cc
[modify] https://crrev.com/ac2d943e806fbc6073a51f751536b03dcdfd60a5/dbus/chromeos_mm1_modem_proxy.cc
[modify] https://crrev.com/ac2d943e806fbc6073a51f751536b03dcdfd60a5/dbus/chromeos_mm1_modem_modemcdma_proxy.cc
[modify] https://crrev.com/ac2d943e806fbc6073a51f751536b03dcdfd60a5/dbus/chromeos_modem_gobi_proxy.cc
[modify] https://crrev.com/ac2d943e806fbc6073a51f751536b03dcdfd60a5/dbus/chromeos_modem_gsm_card_proxy.cc
[modify] https://crrev.com/ac2d943e806fbc6073a51f751536b03dcdfd60a5/dbus/chromeos_dbus_objectmanager_proxy.cc
[modify] https://crrev.com/ac2d943e806fbc6073a51f751536b03dcdfd60a5/dbus/chromeos_mm1_modem_simple_proxy.cc
[modify] https://crrev.com/ac2d943e806fbc6073a51f751536b03dcdfd60a5/dbus/chromeos_modem_proxy.cc
[modify] https://crrev.com/ac2d943e806fbc6073a51f751536b03dcdfd60a5/dbus/chromeos_mm1_modem_location_proxy.cc
[modify] https://crrev.com/ac2d943e806fbc6073a51f751536b03dcdfd60a5/dbus/chromeos_modem_simple_proxy.cc
[modify] https://crrev.com/ac2d943e806fbc6073a51f751536b03dcdfd60a5/dbus/chromeos_mm1_sim_proxy.cc
[modify] https://crrev.com/ac2d943e806fbc6073a51f751536b03dcdfd60a5/dbus/chromeos_mm1_modem_modem3gpp_proxy.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment