Let's limit Worklets only to secure contexts based on the decision on the intent-to-ship thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Jex3idOld48/VeOxMUNDBAAJ Note that this restriction could be removed later based on policy decision.
WIP CL: https://chromium-review.googlesource.com/c/chromium/src/+/746494
Spec issue: https://github.com/w3c/css-houdini-drafts/issues/505
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2bfbd58e062385c2585ef4e11058c7777d5581e commit b2bfbd58e062385c2585ef4e11058c7777d5581e Author: Hitoshi Yoshida <peria@chromium.org> Date: Fri Nov 10 01:42:36 2017 bindings: Support [SecureContext] on static attributes in partial interface In bindings layer, we did not take care of [SecureContext] extended attribute on contexts and static attributes (i.e. on-interface properties) of partial interfaces. This CL makes those interface members accessible only if the context is secure. Bug: 779938 , 782121 Change-Id: Iff5a5b85ce8d9b4bd20871298b93b60c054246ba Reviewed-on: https://chromium-review.googlesource.com/758278 Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#515408} [modify] https://crrev.com/b2bfbd58e062385c2585ef4e11058c7777d5581e/third_party/WebKit/Source/bindings/scripts/v8_interface.py [modify] https://crrev.com/b2bfbd58e062385c2585ef4e11058c7777d5581e/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl [modify] https://crrev.com/b2bfbd58e062385c2585ef4e11058c7777d5581e/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl [modify] https://crrev.com/b2bfbd58e062385c2585ef4e11058c7777d5581e/third_party/WebKit/Source/bindings/tests/idls/modules/TestInterfacePartial4.idl [modify] https://crrev.com/b2bfbd58e062385c2585ef4e11058c7777d5581e/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp [modify] https://crrev.com/b2bfbd58e062385c2585ef4e11058c7777d5581e/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.cpp [modify] https://crrev.com/b2bfbd58e062385c2585ef4e11058c7777d5581e/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp [modify] https://crrev.com/b2bfbd58e062385c2585ef4e11058c7777d5581e/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1588705ebeb353d9be5a29e169ea724742ceebdc commit 1588705ebeb353d9be5a29e169ea724742ceebdc Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Tue Nov 14 09:55:22 2017 Worklet: Disallow Worklets on insecure contexts This CL disallows Worklets on insecure contexts based on the decision on the intent-to-ship thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Jex3idOld48/VeOxMUNDBAAJ Bug: 779938 Change-Id: I5fde5f15f444769c4e7f08b1a7ae7746717707f0 Reviewed-on: https://chromium-review.googlesource.com/746494 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#516248} [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/background-image-alpha.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/background-image-multiple.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/background-image-tiled.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/geometry-background-image-001.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/geometry-background-image-002.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/geometry-background-image-tiled-001.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/geometry-background-image-tiled-002.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/geometry-background-image-tiled-003.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/geometry-border-image-001.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/geometry-border-image-002.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/geometry-border-image-003.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/geometry-border-image-004.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/hidpi/device-pixel-ratio.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/invalid-image-constructor-error.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/invalid-image-paint-error.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/invalid-image-pending-script.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/overdraw.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/paint-arguments.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/paint-function-arguments.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/paint2d-composite.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/paint2d-filter.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/paint2d-gradient.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/paint2d-image.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/paint2d-paths.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/paint2d-rects.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/paint2d-shadows.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/paint2d-transform.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/parse-input-arguments-001.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/parse-input-arguments-002.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/parse-input-arguments-003.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/parse-input-arguments-004.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/parse-input-arguments-005.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/parse-input-arguments-006.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/parse-input-arguments-007.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/parse-input-arguments-008.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/parse-input-arguments-009.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/parse-input-arguments-010.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/parse-input-arguments-011.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/parse-input-arguments-012.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/parse-input-arguments-013.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/parse-input-arguments-014.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/parse-input-arguments-015.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/parse-input-arguments-016.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/parse-input-arguments-017.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/parse-input-arguments-018.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/parse-input-arguments-019.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/parse-input-arguments-020.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/parse-input-arguments-021.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/parse-input-arguments-022.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/registered-properties-in-custom-paint.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/style-background-image.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/style-before-pseudo.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/style-first-letter-pseudo.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/valid-image-after-load.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/valid-image-before-load.https.html [modify] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/lint.whitelist [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/worklets/animation-worklet-credentials.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/worklets/animation-worklet-import.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/worklets/animation-worklet-referrer.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/worklets/paint-worklet-credentials.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/worklets/paint-worklet-import.https.html [rename] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/worklets/paint-worklet-referrer.https.html [modify] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/worklets/resources/credentials-tests.js [modify] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-tests.js [modify] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/external/wpt/worklets/resources/referrer-window.html [add] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/LayoutTests/http/tests/worklet/chromium/import-on-insecure-context.html [modify] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/Source/core/workers/Worklet.idl [modify] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/Source/modules/animationworklet/WindowAnimationWorklet.cpp [modify] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/Source/modules/animationworklet/WindowAnimationWorklet.idl [modify] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/Source/modules/csspaint/CSSPaintWorklet.idl [modify] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp [modify] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/Source/modules/webaudio/WindowAudioWorklet.cpp [modify] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/Source/modules/webaudio/WindowAudioWorklet.h [modify] https://crrev.com/1588705ebeb353d9be5a29e169ea724742ceebdc/third_party/WebKit/Source/modules/webaudio/WindowAudioWorklet.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4318c06d949e678981bf5abec17c520623c664a6 commit 4318c06d949e678981bf5abec17c520623c664a6 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Fri Nov 17 04:36:45 2017 Worklet: Add [SecureContext] to WindowAnimationWorklet and WindowAudioWorklet [SecureContext] attribute was not supported on 'partial interface' and 'attribute', but peria@'s CL[1] fixed this issue. This CL replaces workarounds with the proper [SecureContext] on WindowAnimationWorklet and WindowAudioWorklet. [1] https://chromium-review.googlesource.com/c/chromium/src/+/765607 Bug: 779938 Change-Id: I96ed100c9937217e70e7ae4db7d6576305e05f25 Reviewed-on: https://chromium-review.googlesource.com/774338 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#517301} [modify] https://crrev.com/4318c06d949e678981bf5abec17c520623c664a6/third_party/WebKit/LayoutTests/http/tests/worklet/import-on-insecure-context.html [modify] https://crrev.com/4318c06d949e678981bf5abec17c520623c664a6/third_party/WebKit/Source/modules/animationworklet/WindowAnimationWorklet.cpp [modify] https://crrev.com/4318c06d949e678981bf5abec17c520623c664a6/third_party/WebKit/Source/modules/animationworklet/WindowAnimationWorklet.idl [modify] https://crrev.com/4318c06d949e678981bf5abec17c520623c664a6/third_party/WebKit/Source/modules/webaudio/WindowAudioWorklet.cpp [modify] https://crrev.com/4318c06d949e678981bf5abec17c520623c664a6/third_party/WebKit/Source/modules/webaudio/WindowAudioWorklet.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0ad983de83697febc63ddc277cb28eb5bd48da8 commit b0ad983de83697febc63ddc277cb28eb5bd48da8 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Tue Nov 21 03:33:10 2017 Revert "Worklet: Add [SecureContext] to WindowAnimationWorklet and WindowAudioWorklet" This reverts commit 4318c06d949e678981bf5abec17c520623c664a6. Reason for revert: This CL works for test environments but unexpectedly disables window.animationWorklet and window.AudioWorklet on non-test environments. Original change's description: > Worklet: Add [SecureContext] to WindowAnimationWorklet and WindowAudioWorklet > > [SecureContext] attribute was not supported on 'partial interface' and > 'attribute', but peria@'s CL[1] fixed this issue. > > This CL replaces workarounds with the proper [SecureContext] on > WindowAnimationWorklet and WindowAudioWorklet. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/765607 > > Bug: 779938 > Change-Id: I96ed100c9937217e70e7ae4db7d6576305e05f25 > Reviewed-on: https://chromium-review.googlesource.com/774338 > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517301} TBR=haraken@chromium.org,nhiroki@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 779938 , 786750 Change-Id: I0718a6eb21dfc589fe4cbc4b0e818eeb4b6910d1 Reviewed-on: https://chromium-review.googlesource.com/780159 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#518090} [modify] https://crrev.com/b0ad983de83697febc63ddc277cb28eb5bd48da8/third_party/WebKit/LayoutTests/http/tests/worklet/import-on-insecure-context.html [modify] https://crrev.com/b0ad983de83697febc63ddc277cb28eb5bd48da8/third_party/WebKit/Source/modules/animationworklet/WindowAnimationWorklet.cpp [modify] https://crrev.com/b0ad983de83697febc63ddc277cb28eb5bd48da8/third_party/WebKit/Source/modules/animationworklet/WindowAnimationWorklet.idl [modify] https://crrev.com/b0ad983de83697febc63ddc277cb28eb5bd48da8/third_party/WebKit/Source/modules/webaudio/WindowAudioWorklet.cpp [modify] https://crrev.com/b0ad983de83697febc63ddc277cb28eb5bd48da8/third_party/WebKit/Source/modules/webaudio/WindowAudioWorklet.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a4e27575e8c7558ceddd2d7b8724a4d254670a6 commit 5a4e27575e8c7558ceddd2d7b8724a4d254670a6 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Fri Nov 24 02:52:21 2017 Revert "Revert "Worklet: Add [SecureContext] to WindowAnimationWorklet and WindowAudioWorklet"" This reverts commit b0ad983de83697febc63ddc277cb28eb5bd48da8. Reason for revert: The fix was landed in https://chromium-review.googlesource.com/c/chromium/src/+/778642 Original change's description: > Revert "Worklet: Add [SecureContext] to WindowAnimationWorklet and WindowAudioWorklet" > > This reverts commit 4318c06d949e678981bf5abec17c520623c664a6. > > Reason for revert: > This CL works for test environments but unexpectedly disables window.animationWorklet and window.AudioWorklet on non-test environments. > > Original change's description: > > Worklet: Add [SecureContext] to WindowAnimationWorklet and WindowAudioWorklet > > > > [SecureContext] attribute was not supported on 'partial interface' and > > 'attribute', but peria@'s CL[1] fixed this issue. > > > > This CL replaces workarounds with the proper [SecureContext] on > > WindowAnimationWorklet and WindowAudioWorklet. > > > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/765607 > > > > Bug: 779938 > > Change-Id: I96ed100c9937217e70e7ae4db7d6576305e05f25 > > Reviewed-on: https://chromium-review.googlesource.com/774338 > > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#517301} > > TBR=haraken@chromium.org,nhiroki@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 779938 , 786750 > Change-Id: I0718a6eb21dfc589fe4cbc4b0e818eeb4b6910d1 > Reviewed-on: https://chromium-review.googlesource.com/780159 > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#518090} TBR=haraken@chromium.org,nhiroki@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 779938 , 786750 Change-Id: I0fce8d06bb6d67b04fa572a1147cfbe16ae5e129 Reviewed-on: https://chromium-review.googlesource.com/788552 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#519047} [modify] https://crrev.com/5a4e27575e8c7558ceddd2d7b8724a4d254670a6/third_party/WebKit/LayoutTests/http/tests/worklet/import-on-insecure-context.html [modify] https://crrev.com/5a4e27575e8c7558ceddd2d7b8724a4d254670a6/third_party/WebKit/Source/modules/animationworklet/WindowAnimationWorklet.cpp [modify] https://crrev.com/5a4e27575e8c7558ceddd2d7b8724a4d254670a6/third_party/WebKit/Source/modules/animationworklet/WindowAnimationWorklet.idl [modify] https://crrev.com/5a4e27575e8c7558ceddd2d7b8724a4d254670a6/third_party/WebKit/Source/modules/webaudio/WindowAudioWorklet.cpp [modify] https://crrev.com/5a4e27575e8c7558ceddd2d7b8724a4d254670a6/third_party/WebKit/Source/modules/webaudio/WindowAudioWorklet.idl
Comment 1 by nhiroki@chromium.org
, Oct 31 2017