New issue
Advanced search Search tips

Issue 779937 link

Starred by 1 user
Status: Fixed
Owner:
tapted@chromium.org
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

views_unittests LabelButtonTest.ButtonStyleIsDefaultStyle failing on macOS 10.10 (only)

Project Member Reported by tapted@chromium.org, Oct 31 2017 
Chrome Version       : r512704
OS Version: OS X 10.10

This regressed in r512704 due to a new confluence of layout parameters. Only 10.10 is affected.

Error is 

[ RUN      ] LabelButtonTest.ButtonStyleIsDefaultStyle
../../ui/views/controls/button/label_button_unittest.cc:399: Failure
Expected: (non_default_size) != (button->label()->size()), actual: 29x32 vs 29x32
[  FAILED  ] LabelButtonTest.ButtonStyleIsDefaultStyle (131 ms)
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad3436a1b7ffd85b9847f39c508070c985cf060d

commit ad3436a1b7ffd85b9847f39c508070c985cf060d
Author: Trent Apted <tapted@chromium.org>
Date: Tue Oct 31 06:32:05 2017

Disable LabelButtonTest.ButtonStyleIsDefaultStyle on Mac

This fails on 10.10 only because the system bold font doesn't change its
width enough to cause the test expecations to fail. But we don't care
about styled LabelButtons on Mac -- just MdTextButton, so just disable
on Mac.

TBR=ellyjones@chromium.org

Bug:  779937 
Change-Id: I941c6b0ce9ee7bd6e4794519c7a6129e0dace7d5
Reviewed-on: https://chromium-review.googlesource.com/746064
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512763}
[modify] https://crrev.com/ad3436a1b7ffd85b9847f39c508070c985cf060d/ui/views/controls/button/label_button_unittest.cc

Comment 2 by tapted@chromium.org, Feb 13 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment