New issue
Advanced search Search tips

Issue 779934 link

Starred by 1 user
Status: Fixed
Owner:
dougarnett@chromium.org
Closed: Dec 2017
Cc:
bengr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Flaky browser test: PreviewsBrowserTest.NoScriptPreviewsEnabled on Win/Mac

Project Member Reported by shimazu@chromium.org, Oct 31 2017 
There are several flaky failure of the test on the flakiness dashboard.
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=PreviewsBrowserTest.NoScriptPreviewsEnabled

This is the failing build log:
https://chromium-swarm.appspot.com/task?id=39898a6ae3448210&refresh=10&show_raw=1

and the following is the failure messages:

../../chrome/browser/previews/previews_browsertest.cc(88): error: Value of: noscript_css_requested()

  Actual: false

Expected: true

../../chrome/browser/previews/previews_browsertest.cc(89): error: Value of: noscript_js_requested()

  Actual: true

Expected: false
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25204dc502fd38ae95a9c0520f98d4b29a6bbab3

commit 25204dc502fd38ae95a9c0520f98d4b29a6bbab3
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Tue Oct 31 06:35:00 2017

Disable PreviewsBrowserTest.NoScriptPreviewsEnabled on Win/Mac

TBR=dougarnett@chromium.org

Bug:  779934 ,  773834 
Change-Id: I40632e362538aee524161b5d1fa9bcd824273dfa
Reviewed-on: https://chromium-review.googlesource.com/746063
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512765}
[modify] https://crrev.com/25204dc502fd38ae95a9c0520f98d4b29a6bbab3/chrome/browser/previews/previews_browsertest.cc

Comment 2 by shimazu@chromium.org, Nov 1 2017

Labels: -Sheriff-Chromium
Removed Sheriff-Chromium since the test has been disabled.

Comment 3 by bengr@chromium.org, Nov 1 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32ce91ea9116423e1f310ff2aa5d4bdfc695884b

commit 32ce91ea9116423e1f310ff2aa5d4bdfc695884b
Author: Doug Arnett <dougarnett@chromium.org>
Date: Tue Nov 07 21:42:30 2017

Fixes previews_browsertest flakiness wrt NoScript feature initialization

Adds test subclass that now enable NoScriptPreviews via SetUpCommandLine

Bug:  779934 
Change-Id: I077e4c9ddac17694dd02ba641d3bc1b8da833316
Reviewed-on: https://chromium-review.googlesource.com/754298
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514607}
[modify] https://crrev.com/32ce91ea9116423e1f310ff2aa5d4bdfc695884b/chrome/browser/previews/previews_browsertest.cc

Comment 5 by dougarnett@chromium.org, Dec 4 2017

Status: Fixed (was: Started)

Comment 6 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 7 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews
►

Sign in to add a comment