Should we optimize png file size with loseless compression in Bling? |
||||
Issue descriptionIn Clank, png files are optimized before submitted. https://docs.google.com/document/d/1qtbkmgI5LHmYQ2bS3wgOg225OXIS25G84jsF_XW2sy0/edit#heading=h.n61h434m57v1 Should we do the same for Bling? I did an experiment: crrev.com/c/745705 Optimize Bling's pngs using tools/resources/optimize-png-files.sh It could save 248KB of file sizes in total. In my experiment, the pngs are optimized by the following steps: 1. Modify the ALL_DIRS in tools/resources/optimize-png-files.sh using the image folders found from the following: https://cs.chromium.org/search/?q=f:%22src/ios%22+f:json+%22.png%22+-f:third_party+-f:src/chrome/test&m=1000&det=none&type=cs 2. Then run the modified optimize-png-files.sh in a Goobuntu machine. Any thought?
,
Nov 2 2017
None of the Chrome on iOS developer has an ubuntu machine, so unless the script is modified to work on macOS we cannot use it. Marking as Available.
,
Nov 2
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 7
It looks like this script uses pngcrush? We can build pngcrush with homebrew, and store it in cipd maybe? pschaffner@ do we still want to do this?
,
Nov 8
It could make our bundle smaller, which is good ... so yeah why not. |
||||
►
Sign in to add a comment |
||||
Comment 1 by sczs@chromium.org
, Nov 1 2017Owner: sdefresne@chromium.org
Status: Assigned (was: Untriaged)