Transformed overflow:hidden does not clip contents when nested inside a scroller |
||
Issue descriptionWhen investigating a root-layer-scrolling test failure on paint/invalidation/scroll-in-transformed-layer.html, I found we have an overflow scroll clipping bug. See the attached testcase.
,
Nov 1 2017
,
Nov 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4646c30050ea81ac922d558cb185e540e0b82326 commit 4646c30050ea81ac922d558cb185e540e0b82326 Author: Philip Rogers <pdr@chromium.org> Date: Wed Nov 01 21:30:02 2017 Ensure negative z index children are painted in scrollers [1] ensured kPaintLayerPaintingOverflowContents was cleared when painting a new root but failed to clear kPaintLayerPaintingCompositingScrollingPhase as well. This caused a regression where negative z index children of a scrolled and transformed paint layer would not paint. This patch fixes and tests the regression from [1], as well as passing one additional test with root layer scrolling. [1] https://crrev.com/19f7cb8adfd015bef06b08d0c02eb5a528e8c885 Bug: 779885 Change-Id: Id73ae360000efe866fd9c9c7c1dade186d547cac Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/749059 Reviewed-by: Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#513276} [modify] https://crrev.com/4646c30050ea81ac922d558cb185e540e0b82326/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls [add] https://crrev.com/4646c30050ea81ac922d558cb185e540e0b82326/third_party/WebKit/LayoutTests/compositing/overflow/overflow-with-negative-z-index-child-expected.html [add] https://crrev.com/4646c30050ea81ac922d558cb185e540e0b82326/third_party/WebKit/LayoutTests/compositing/overflow/overflow-with-negative-z-index-child.html [modify] https://crrev.com/4646c30050ea81ac922d558cb185e540e0b82326/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Nov 1 2017