New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 779884 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

implement the not implemented methods in exo::wayland

Project Member Reported by za...@chromium.org, Oct 31 2017

Issue description

There are a few not implemented things being used by some of the wayland apps we are running in the containers project.

This one comes up every time we try to open a drop down box. This actually seems to result in the drop down box never appearing:
[10127:10127:1030/175411.411219:ERROR:server.cc(1270)] Not implemented reached in void exo::wayland::(anonymous namespace)::xdg_positioner_v6_set_size(wl_client *, wl_resource *, int32_t, int32_t)
[10127:10127:1030/175411.411281:ERROR:server.cc(1279)] Not implemented reached in void exo::wayland::(anonymous namespace)::xdg_positioner_v6_set_anchor_rect(wl_client *, wl_resource *, int32_t, int32_t, int32_t, int32_t)
[10127:10127:1030/175411.411297:ERROR:server.cc(1305)] Not implemented reached in void exo::wayland::(anonymous namespace)::xdg_positioner_v6_set_offset(wl_client *, wl_resource *, int32_t, int32_t)
[10127:10127:1030/175411.411305:ERROR:server.cc(1285)] Not implemented reached in void exo::wayland::(anonymous namespace)::xdg_positioner_v6_set_anchor(wl_client *, wl_resource *, uint32_t)
[10127:10127:1030/175411.411312:ERROR:server.cc(1291)] Not implemented reached in void exo::wayland::(anonymous namespace)::xdg_positioner_v6_set_gravity(wl_client *, wl_resource *, uint32_t)
[10127:10127:1030/175411.411319:ERROR:server.cc(1298)] Not implemented reached in void exo::wayland::(anonymous namespace)::xdg_positioner_v6_set_constraint_adjustment(wl_client *, wl_resource *, uint32_t)
[10127:10127:1030/175411.411330:ERROR:server.cc(1464)] Not implemented reached in void exo::wayland::(anonymous namespace)::xdg_popup_v6_grab(wl_client *, wl_resource *, wl_resource *, uint32_t)

These errors happen nearly constantly while a window is being handled:
[10127:10127:1030/175410.971332:ERROR:server.cc(1411)] Not implemented reached in void exo::wayland::(anonymous namespace)::xdg_toplevel_v6_set_min_size(wl_client *, wl_resource *, int32_t, int32_t)
[10127:10127:1030/175410.971375:ERROR:server.cc(1404)] Not implemented reached in void exo::wayland::(anonymous namespace)::xdg_toplevel_v6_set_max_size(wl_client *, wl_resource *, int32_t, int32_t)

This error is easiest to trigger by opening the context menu in the client side decorations in a gtk3 app. In some circumstances, there are visual glitches with the opening animation as if the buffer pixels are damaged:
[10127:10127:1030/175255.098768:ERROR:sub_surface.cc(100)] Not implemented reached in virtual void exo::SubSurface::OnSurfaceCommit()Async subsurface is not supported!
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92d62924cd922e2162cd072449d7484d189d7177

commit 92d62924cd922e2162cd072449d7484d189d7177
Author: David Reveman <reveman@chromium.org>
Date: Thu Nov 02 17:18:35 2017

exo: Implement XDG shell set_{min,max}_size

Chrome doesn't do much with this yet and that's not required
by the protocol but this at least accepts the state so it
can be used in the future when appropriate (e.g. respect
maximum size when maximizing a window).

Bug:  779884 
Test: exo_unittests --gtest_filter=ShellSurfaceTest.Set*Size
Change-Id: I120c598c5d2bebba65e9936889b4227c8b94e644
Reviewed-on: https://chromium-review.googlesource.com/749648
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513527}
[modify] https://crrev.com/92d62924cd922e2162cd072449d7484d189d7177/components/exo/shell_surface.cc
[modify] https://crrev.com/92d62924cd922e2162cd072449d7484d189d7177/components/exo/shell_surface.h
[modify] https://crrev.com/92d62924cd922e2162cd072449d7484d189d7177/components/exo/shell_surface_unittest.cc
[modify] https://crrev.com/92d62924cd922e2162cd072449d7484d189d7177/components/exo/wayland/server.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/396795d18b5a488d00a6b2996fe6ab0713da5dc0

commit 396795d18b5a488d00a6b2996fe6ab0713da5dc0
Author: David Reveman <reveman@chromium.org>
Date: Thu Nov 02 18:18:34 2017

exo: Set default configure callback for XDG surfaces

This is needed for popup surfaces to get configure events. Clients
rely on these events for initial commit.

Bug:  779884 
Test: gtk3-demo
Change-Id: I0e5a2a08b4fb1f81aec50c430145b574a6a3fe9e
Reviewed-on: https://chromium-review.googlesource.com/750643
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513556}
[modify] https://crrev.com/396795d18b5a488d00a6b2996fe6ab0713da5dc0/components/exo/wayland/server.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74e01b054b2759a7de9868bbfe4d23a877e4b5d5

commit 74e01b054b2759a7de9868bbfe4d23a877e4b5d5
Author: David Reveman <reveman@chromium.org>
Date: Thu Nov 02 22:25:33 2017

exo: Implement XDG shell positioner

This allows popup windows to be positioned correctly.

Bug:  779884 
Test: exo_unittests
Test: gtk3-demo
Change-Id: I1ecded9afc97fd6cb8f3a8fc27aaef4f55daec1a
Reviewed-on: https://chromium-review.googlesource.com/751407
Commit-Queue: David Reveman <reveman@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513618}
[modify] https://crrev.com/74e01b054b2759a7de9868bbfe4d23a877e4b5d5/components/exo/shell_surface.cc
[modify] https://crrev.com/74e01b054b2759a7de9868bbfe4d23a877e4b5d5/components/exo/shell_surface.h
[modify] https://crrev.com/74e01b054b2759a7de9868bbfe4d23a877e4b5d5/components/exo/shell_surface_unittest.cc
[modify] https://crrev.com/74e01b054b2759a7de9868bbfe4d23a877e4b5d5/components/exo/wayland/server.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c01e4789e4c0fcaa0528a5812b83d3a83c85094b

commit c01e4789e4c0fcaa0528a5812b83d3a83c85094b
Author: David Reveman <reveman@chromium.org>
Date: Mon Nov 06 18:21:06 2017

exo: Fix popup position when using aura shell.

Fix conversion to screen coordinates when using aura shell.
Parent widget might have a frame when aura shell interface
is used. Converting from contents view coordinates will
always give the correct result.

This also makes XDG popups use system modal container to be
consistent with wl_shell popups.

Bug:  779884 
Test: 'xwl-run xfontsel' and verified that popups are placed correctly
Change-Id: Ida791f5ab96f04a58841cb9140399822ecaff52e
Reviewed-on: https://chromium-review.googlesource.com/754557
Commit-Queue: David Reveman <reveman@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514183}
[modify] https://crrev.com/c01e4789e4c0fcaa0528a5812b83d3a83c85094b/components/exo/wayland/server.cc

Owner: reve...@chromium.org
Status: Fixed (was: Untriaged)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 7 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
Components: OS>Systems>Containers

Sign in to add a comment