When showing sound setting in Page Info due to sound playing, leave in Page Info until navigation |
|||||
Issue descriptionCurrently, the sound content setting will show up in the Page Info bubble when audio plays on the site, even when the setting is in the default state. However, as currently implemented, the setting will no longer be there once sound ceases to play. Instead, the setting should remain visible in Page Info until a navigation occurs
,
Nov 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1836051712700b4abfd54361aab9a13f6203dac5 commit 1836051712700b4abfd54361aab9a13f6203dac5 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 01 00:38:19 2017 Continue showing sound setting in Page Info until navigation This CL adds a WasEverAudible method to WebContents which returns true if audio has played since the last navigation. This is then used by the Page Info bubble to decide whether or not to show the sound content setting. Bug: 779878 Change-Id: I66453161dfe17df6868e66f11e7fce0b3c3a87b8 Reviewed-on: https://chromium-review.googlesource.com/747069 Reviewed-by: Lucas Garron <lgarron@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#513025} [modify] https://crrev.com/1836051712700b4abfd54361aab9a13f6203dac5/chrome/browser/ui/page_info/page_info.cc [modify] https://crrev.com/1836051712700b4abfd54361aab9a13f6203dac5/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/1836051712700b4abfd54361aab9a13f6203dac5/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/1836051712700b4abfd54361aab9a13f6203dac5/content/public/browser/web_contents.h
,
Nov 1 2017
steimel@ Tested this issue by following the steps mentioned in issue 777275 on Windows 7, Mac OS 10.12.6 and Ubuntu 14.04 using the latest Chrome version 64.0.3255.0 and can observe that after changing the values in the site setting page, and did not reload the page, the newly applied values are shown instead of the default ones in the site setting page. Attached is the screen cast for reference. Can you please check and confirm if this fix is working as intended? Thanks..
,
Nov 1 2017
Hi Susan. This issue is actually a bit different from issue 777275 , and I'll post a screencast of it on here soon, but I actually believe that your screencast isn't properly testing issue 777275 either. Issue 777275 is that when a setting is showing up in the popup because it's in a non-default state, and the user changes the setting within the popup to the default setting, and then closes/reopens the popup, the setting is gone. I'm attaching a screencast to show issue 777275 . At time 0:21, you can see the javascript setting showing up in the popup. Then at 0:29 I change the setting to the default. Then I close and reopen the popup and at 0:36 you can see that the javascript setting has disappeared. Also note that this issue will not solve the problem I'm showing in this screencast
,
Nov 1 2017
Now here's a screencast showing the problem that this crbug is solving. At 0:04, no sound has played yet and the sound setting is *not* displayed in the bubble (this is good). Then sound starts playing and at 0:18 you can see that the sound setting is displayed in the bubble (this is good). Then sound stops playing and at 0:30 you can see that the sound setting is no longer displaying in the bubble (this is bad). This is now fixed on desktop (Android fix still in progress). Thanks!
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4844b7c4f22afe60ac9091ce1530e05a5c58d8a2 commit 4844b7c4f22afe60ac9091ce1530e05a5c58d8a2 Author: Tommy Steimel <steimel@chromium.org> Date: Thu Nov 02 16:24:43 2017 Show sound setting in Page Info when sound has played on Android This CL updates Android to show the sound content setting in the Page Info bubble when sound has played on a site since last navigation. Bug: 779878 Change-Id: I441098cf83f47cef9df99337f80f55daee47097a Reviewed-on: https://chromium-review.googlesource.com/749846 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#513509} [modify] https://crrev.com/4844b7c4f22afe60ac9091ce1530e05a5c58d8a2/chrome/browser/ui/android/page_info/page_info_popup_android.cc [modify] https://crrev.com/4844b7c4f22afe60ac9091ce1530e05a5c58d8a2/chrome/browser/ui/android/page_info/page_info_popup_android.h
,
Nov 2 2017
,
Nov 2 2017
,
Nov 3 2017
Verified this issue on Mac OS 10.12.6 using latest chrome build 64.0.3257.0 by following steps mentioned in comment #5. Observed that the sound setting is seen even when we stop playing the audio in the latest version of Chrome. Attaching screen-shot for reference. Hence adding TE-Verified labels. Thanks..
,
Nov 3 2017
// correction in comment #9 Verified this issue on Windows 7, Mac OS 10.12.6 and Ubuntu 14.04. Thanks.. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by timloh@chromium.org
, Oct 31 2017