New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 779873 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 661174



Sign in to add a comment

Failing w3c test for clip() - output is space-separated instead of comma-separated

Project Member Reported by meade@chromium.org, Oct 31 2017

Issue description

Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1) Go to http://w3c-test.org/cssom/serialize-values.html
(2)
(3)

What is the expected result?


What happens instead?

Fail	clip: rect(1em, auto, 0.5px, 2000em)	

assert_equals: clip raw inline style declaration expected "rect(1em, auto, 0.5px, 2000em)" but got "rect(1em auto 0.5px 2000em)"
    at Test.<anonymous> (http://w3c-test.org/cssom/serialize-values.html:234:9)
    at Test.step (http://w3c-test.org/resources/testharness.js:1489:25)
    at run_individual_test (http://w3c-test.org/cssom/serialize-values.html:230:9)
    at test_property (http://w3c-test.org/cssom/serialize-values.html:245:14)
    at http://w3c-test.org/cssom/serialize-values.html:593:7
 

Comment 1 by meade@chromium.org, Oct 31 2017

Labels: Update-Quarterly

Comment 2 by meade@chromium.org, Oct 31 2017

Blocking: 661174
Owner: shanmug...@samsung.com
Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/574061c0705e35233fa667e969bc66e9403146ff

commit 574061c0705e35233fa667e969bc66e9403146ff
Author: Shanmuga Pandi M <shanmuga.m@samsung.com>
Date: Tue Nov 14 16:14:51 2017

Make clip() output as comma-seperated.

serialize value of clip attribute expected as comma-seperated.
So change it from space-separated to comma-seperated.

Bug:  779873 
Change-Id: Ia2726bd1fcfa0b5c9e4eca1fcd71a4d4f269c332
Reviewed-on: https://chromium-review.googlesource.com/760178
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#516317}
[modify] https://crrev.com/574061c0705e35233fa667e969bc66e9403146ff/third_party/WebKit/LayoutTests/external/wpt/css/cssom/serialize-values-expected.txt
[modify] https://crrev.com/574061c0705e35233fa667e969bc66e9403146ff/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/iterationComposite-expected.txt
[modify] https://crrev.com/574061c0705e35233fa667e969bc66e9403146ff/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-clip.html
[modify] https://crrev.com/574061c0705e35233fa667e969bc66e9403146ff/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-with-zoom-expected.txt
[modify] https://crrev.com/574061c0705e35233fa667e969bc66e9403146ff/third_party/WebKit/LayoutTests/fast/css/getPropertyValue-clip.html
[modify] https://crrev.com/574061c0705e35233fa667e969bc66e9403146ff/third_party/WebKit/LayoutTests/fast/css/parsing-unitless-length-quirk.html
[modify] https://crrev.com/574061c0705e35233fa667e969bc66e9403146ff/third_party/WebKit/Source/core/css/CSSQuadValue.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment