New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 779871 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 769402



Sign in to add a comment

[MD Extensions] Allow in incogito icon not showing warning when clicked.

Project Member Reported by dpa...@chromium.org, Oct 31 2017

Issue description

Clicking on the "i" info icon next to the "Allow in incognito" is supposed to show a text warning IIUC. Currently clicking on the icon changes the state of the toggle instead of showing any information.
 
no_tooltip_warning.mp4
70.0 KB View Download

Comment 1 by dpa...@chromium.org, Oct 31 2017

Blocking: 769402
Since this is privacy related, I think it should block the Dev channel release.
Status: Started (was: Available)
Cc: -catmulli...@chromium.org
Owner: catmulli...@chromium.org
Cc: bettes@chromium.org
+bettes

Clarification: When I filed the bug I mentioned "not showing warning when clicked", but thinking about this again, I am not sure if it should show on 'cilck' or on hover.

@bettes: Any thoughts on this?

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c22a8c67597f2c801b424f9cff4f6e6fd44bab12

commit c22a8c67597f2c801b424f9cff4f6e6fd44bab12
Author: Catherine Mullings <catmullings@chromium.org>
Date: Fri Nov 03 04:18:27 2017

MD Extensions: Add tooltip for incognito icon in detail view page

Added tooltip on hover for "Allow in incognito" icon in the detail view
page. Also, prevented clicking the icon to toggle incognito enablement.

Bug:  779871 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5a5854136a19ab818e3495a2f4235ebc29cb9366
Reviewed-on: https://chromium-review.googlesource.com/749055
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: catmullings <catmullings@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513677}
[modify] https://crrev.com/c22a8c67597f2c801b424f9cff4f6e6fd44bab12/chrome/app/chromium_strings.grd
[modify] https://crrev.com/c22a8c67597f2c801b424f9cff4f6e6fd44bab12/chrome/app/google_chrome_strings.grd
[modify] https://crrev.com/c22a8c67597f2c801b424f9cff4f6e6fd44bab12/chrome/browser/resources/md_extensions/detail_view.html
[modify] https://crrev.com/c22a8c67597f2c801b424f9cff4f6e6fd44bab12/chrome/browser/resources/md_extensions/detail_view.js
[modify] https://crrev.com/c22a8c67597f2c801b424f9cff4f6e6fd44bab12/chrome/browser/ui/webui/extensions/extensions_ui.cc

Status: Fixed (was: Started)
Labels: TE-Verified-64.0.3260.0 TE-Verified-M64
Verified the fix on Mac 10.12.6, Win-10 and Ubuntu 14.04 using latest chrome version #64.0.3260.0 as per the comment #0.
Attaching screen cast for reference.
Observed that on hovering on the "i" info icon next to the "Allow in incognito" showed a text warning IIUC, clicking doesn't do anything rather the warning disappears on clicking.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!

779871.webm
3.0 MB View Download

Sign in to add a comment