implicit mockgen dependency |
|||
Issue descriptionhttps://cs.chromium.org/chromium/infra/go/src/infra/appengine/sheriff-o-matic/som/client/mock/generate.go?l=3 depends on presence of mockgen which is not declared anywhere in infra.git and not present in $PATH. This prevents others to simply run go generate in SOM. please declare the dependency explicitly see https://chromium.googlesource.com/infra/infra/+/master/go/README.md#Dependency-management consider adding gomock to https://chromium.googlesource.com/infra/infra/+/0bd11f4e91c94a5d17b81d5a575a939898e47583/go/bootstrap.py#118
,
Oct 31 2017
on top of that, it seems that gomock now generates a different package name for milo_mock.go (package mock_proto), so manual changes to the generated files are required, unless i am doing something wrong
,
Oct 31 2017
an alternative to changing bootstrap.py is to include `go install` in go:generate comment
,
Nov 6 2017
,
Apr 30 2018
tandrii fixed it https://chromium-review.googlesource.com/c/infra/infra/+/1033590 |
|||
►
Sign in to add a comment |
|||
Comment 1 by no...@chromium.org
, Oct 31 2017