New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 779853 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Unable to "modem_set_carrier" on Lumpy.

Project Member Reported by dsunk...@chromium.org, Oct 30 2017

Issue description

Chrome Version: 10032.21.0	63.0.3239.26
OS: Chrome OS
DUT: Lumpy with Gobi-3K modem.

What steps will reproduce the problem?
(1) Recover DUT with 10032.21.0
(2) Sign in user account. 
(3) Disable mobile data (Remove any external SIM card plugged into SIM slot)
(4) open crosh terminal and execute "modem_set_carrier Verizon Wireless"

What is the expected result?
It should set the modem to Verizon Wireless. 

What happens instead?
/usr/lib/connectivity-common.sh: line 10: /dev/stderr: Permission denied
message is displayed. 

This used to work fine in M-62. Verified good build on M-62 9901.55.0
 
debug-logs_20171030-163337.tgz
500 KB Download
Cc: vapier@chromium.org
Owner: benchan@chromium.org
Status: Started (was: Untriaged)

Comment 2 by vapier@chromium.org, Oct 31 2017

Labels: -Restrict-View-Google
the issue is that crosh sets up the I/O fifos to be owned/accessible only by chronos (see the `mk_fifo` command in /usr/bin/crosh).  we run shill scripts under "shill-scripts" now which has no access.

/tmp/chronos-temp-*/  700
/tmp/chronos-temp-*/fifo  644

at any rate, redirecting fd's is better than re-opening paths directly.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/fdae449fc3ce29cbf7e29e3749fcf44602d60bd6

commit fdae449fc3ce29cbf7e29e3749fcf44602d60bd6
Author: Ben Chan <benchan@chromium.org>
Date: Tue Oct 31 08:44:39 2017

modem-utilities: fix output to stderr

crosh now runs the 'modem' script via debugd (CL:675733) under the
'shill-scripts' user and group. The 'modem' now fails to write to
/dev/stderr.

BUG= chromium:779853 
TEST=Verify that running `modem set-carrier Foo` under crosh shows an error properly.

Change-Id: I6748225757122b10699aed92404180f2c8efbdd9
Reviewed-on: https://chromium-review.googlesource.com/745403
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/fdae449fc3ce29cbf7e29e3749fcf44602d60bd6/modem-utilities/connectivity-common.sh

Status: Fixed (was: Started)
Labels: Merge-Request-63
Labels: -Type-Bug Type-Bug-Regression
Project Member

Comment 7 by sheriffbot@chromium.org, Oct 31 2017

Labels: -Merge-Request-63 Merge-Review-63 Hotlist-Merge-Review
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-63 Merge-Approved-63
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 3 2017

Labels: merge-merged-release-R63-10032.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/fd4a697f8222b0e34f3c06a9ca8456a7dbc61eef

commit fd4a697f8222b0e34f3c06a9ca8456a7dbc61eef
Author: Ben Chan <benchan@chromium.org>
Date: Fri Nov 03 23:47:13 2017

modem-utilities: fix output to stderr

crosh now runs the 'modem' script via debugd (CL:675733) under the
'shill-scripts' user and group. The 'modem' now fails to write to
/dev/stderr.

BUG= chromium:779853 
TEST=Verify that running `modem set-carrier Foo` under crosh shows an error properly.

Change-Id: I6748225757122b10699aed92404180f2c8efbdd9
Reviewed-on: https://chromium-review.googlesource.com/745403
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
(cherry picked from commit fdae449fc3ce29cbf7e29e3749fcf44602d60bd6)
Reviewed-on: https://chromium-review.googlesource.com/754342
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/fd4a697f8222b0e34f3c06a9ca8456a7dbc61eef/modem-utilities/connectivity-common.sh

Project Member

Comment 10 by sheriffbot@chromium.org, Nov 7 2017

Cc: gkihumba@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-63 Merge-Merged
Status: Verified (was: Fixed)
modem set-carrier now works on lumpy.
M-64 64.0.3282.65/(10176.34.0)

Sign in to add a comment