New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 779852 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make SurveyInfoBar flexible

Project Member Reported by danielpark@chromium.org, Oct 30 2017

Issue description

Make survey info bar flexible enough to be used for all survey cases.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cff432958be44a36f3bcf8b5c196b0f651b9fe1

commit 0cff432958be44a36f3bcf8b5c196b0f651b9fe1
Author: Daniel Park <danielpark@chromium.org>
Date: Mon Nov 06 20:06:22 2017

[Chrome Home Survey] Adds flexibility to SurveyInfoBar

-Allows for different behavior survey info bars by use of 
delegates.

Currently the SurveyInfoBar has behavior specific to Chrome Home.
This patch allows for the info bar to be used in other cases/surveys.

Bug:  779852 
Change-Id: I75338a2f5e32fa8965197f7bb0c9bb62815444a7
Reviewed-on: https://chromium-review.googlesource.com/747891
Commit-Queue: Daniel Park <danielpark@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514219}
[modify] https://crrev.com/0cff432958be44a36f3bcf8b5c196b0f651b9fe1/chrome/android/java/src/org/chromium/chrome/browser/infobar/SurveyInfoBar.java
[add] https://crrev.com/0cff432958be44a36f3bcf8b5c196b0f651b9fe1/chrome/android/java/src/org/chromium/chrome/browser/infobar/SurveyInfoBarDelegate.java
[modify] https://crrev.com/0cff432958be44a36f3bcf8b5c196b0f651b9fe1/chrome/android/java/src/org/chromium/chrome/browser/survey/ChromeHomeSurveyController.java
[modify] https://crrev.com/0cff432958be44a36f3bcf8b5c196b0f651b9fe1/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/0cff432958be44a36f3bcf8b5c196b0f651b9fe1/chrome/android/java_sources.gni
[modify] https://crrev.com/0cff432958be44a36f3bcf8b5c196b0f651b9fe1/chrome/android/junit/src/org/chromium/chrome/browser/survey/ChromeHomeSurveyControllerTest.java
[modify] https://crrev.com/0cff432958be44a36f3bcf8b5c196b0f651b9fe1/chrome/browser/ui/android/infobars/survey_infobar.cc

Status: Fixed (was: Assigned)

Sign in to add a comment