New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 779848 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Maximize button does not use native appearance

Reported by abonneme...@gmail.com, Oct 30 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.75 Safari/537.36

Steps to reproduce the problem:
1. Open Chromium.
2. Make sure the GTK+ theme is enabled in the settings

What is the expected behavior?
The minimize, maximize, and close buttons are displayed using the default system appearance.

What went wrong?
When chromium is maximized, the "zoom button" turns into a square. When hovering it, it looks like a basic gtk button.

Did this work before? Yes Last working version I used: 61.0.3163.100-1, bug could have appeared in the meantime

Chrome version: 62.0.3202.75  Channel: stable
OS Version: 4.9.59-1
Flash Version: 

I'm using XFCE on Manjaro Linux.

It never looked this way, and I'm pretty sure this ugly square isn't a feature. It's not much but that's mildly infuriating.
 
Capture d’écran_2017-10-31_00-41-52.png
9.9 KB View Download
Labels: Needs-Triage-M62
Owner: thomasanderson@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d702c6218a77f480d78bb0fbab5ad9de25599686

commit d702c6218a77f480d78bb0fbab5ad9de25599686
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Mon Nov 06 23:37:40 2017

Gtk3: Fix restore button rendering improperly on some themes

Restore buttons are styled with the ".maxmize" style class, not
".restore".

BUG= 753067 , 779848 
R=erg@chromium.org

Change-Id: Ifcd9f034bddf92285a34be9f1f3d5ea197ee4532
Reviewed-on: https://chromium-review.googlesource.com/755475
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514293}
[modify] https://crrev.com/d702c6218a77f480d78bb0fbab5ad9de25599686/chrome/browser/ui/libgtkui/nav_button_provider_gtk3.cc

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 7 2017

Labels: merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f17ee5c3c4e5cd9a4e6f5f6b7d748780d3030d22

commit f17ee5c3c4e5cd9a4e6f5f6b7d748780d3030d22
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Tue Nov 07 19:05:49 2017

[Merge to M63] Gtk3: Fix restore button rendering improperly on some themes

> Restore buttons are styled with the ".maxmize" style class, not
> ".restore".
>
> BUG= 753067 , 779848 
> R=erg@chromium.org
>
> Change-Id: Ifcd9f034bddf92285a34be9f1f3d5ea197ee4532
> Reviewed-on: https://chromium-review.googlesource.com/755475
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Elliot Glaysher <erg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#514293}

BUG= 753067 , 779848 
TBR=erg@chromium.org
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: I80d3e4bad4cb7b367eb4bbaab3219d8cee9cff5c
Reviewed-on: https://chromium-review.googlesource.com/757500
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#410}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/f17ee5c3c4e5cd9a4e6f5f6b7d748780d3030d22/chrome/browser/ui/libgtkui/nav_button_provider_gtk3.cc

Cc: ranjitkan@chromium.org
Labels: Needs-Feedback
Rechecked this issue on ubuntu 14.04 using chrome build 63.0.3239.40 and observed that for Maximize button on Chrome window applied with GTK theme uses the Native appearance. Screen shot attached.

Request to please confirm if this is the intended behavior.

Thanks.!
Native Buttons.png
318 KB View Download
re c#6: The issue is not reproducible on Ubuntu 14.04.  You need to use 16.04 or later.  I've added repro steps at https://bugs.chromium.org/p/chromium/issues/detail?id=753067#c72
Labels: TE-Verified-M63 TE-Verified-63.0.3239.40
Re checked the issue on Ubuntu 16.04 with chrome version 63.0.3239.40 as per the steps provided in  Issue 753067  in comment#72 & 74 and fix is working as Intended. Tagging issue with TE-Verified labels.

Thanks.!
Thank you all for looking into this issue. I will provide more feedback as soon as the newer release reaches the AUR.

Sign in to add a comment