New issue
Advanced search Search tips

Issue 779841 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 545318



Sign in to add a comment

[css-typed-om] Properties are not sorted correctly in CSSPropertyMap iteration and getProperties.

Project Member Reported by shend@chromium.org, Oct 30 2017

Issue description

Spec: https://drafts.css-houdini.org/css-typed-om-1/#dom-stylepropertymap-getproperties

Test failures: third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/iterable-expected.txt
 
Labels: Code-CSSOM ApproachableBug

Comment 2 by shend@chromium.org, Nov 27 2017

Labels: -Hotlist-Interop
Labels: -Update-Monthly
Owner: hs1217....@samsung.com
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/889ebb251addf7c0ffc6ebc8530170a59c91be64

commit 889ebb251addf7c0ffc6ebc8530170a59c91be64
Author: Hwanseung Lee <hs1217.lee@samsung.com>
Date: Tue Dec 12 02:44:11 2017

[css-typed-om] Sort properties which is from iterator

Sort properties which is from iterator of StylePropertyMapReadOnly
According to spec,
* normal properties are sorted alphabetically.
* custom properties are sorted by increasing code point order.
* custom properties are sorted after normal properties.

present, normal properties has always lower case.
so to sort alphabetical is same effect with sorting code point

https://drafts.css-houdini.org/css-typed-om-1/#dom-stylepropertymap-getproperties

Bug:  779841 
Change-Id: I7532cf2e322073705db2c124fa12116fc38f2345
Reviewed-on: https://chromium-review.googlesource.com/808746
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#523312}
[modify] https://crrev.com/889ebb251addf7c0ffc6ebc8530170a59c91be64/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_iterationWithModification.html
[modify] https://crrev.com/889ebb251addf7c0ffc6ebc8530170a59c91be64/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/iterable-expected.txt
[modify] https://crrev.com/889ebb251addf7c0ffc6ebc8530170a59c91be64/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp

Status: Fixed (was: Started)

Sign in to add a comment