NativeValueTraitsImplTest.IDLCallbackFunction failing in official builds |
|||
Issue descriptionStarted here: https://build.chromium.org/p/chromium.clang/builders/ToTWin%20tester/builds/53 https://build.chromium.org/p/chromium.clang/builders/ToTWin64%20tester/builds/57 Test was added here: https://chromium.googlesource.com/chromium/src/+/2a6c5c9ee3dcb5ca1336a56e2739c24f9d25faa3%5E%21/#F2 I think it's the old "we're testing for the CHECK string in a death test, but we strip test strings in official builds" bug. yukishiino: Just changing ASSERT_DEATH(..., "foo") to ASSERT_DEATH(..., "") will fix this.
,
Oct 31 2017
Thanks for the info!
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df74852f8236bf42e0f2e2a0895e69d535fee45d commit df74852f8236bf42e0f2e2a0895e69d535fee45d Author: Yuki Shiino <yukishiino@chromium.org> Date: Tue Oct 31 13:29:09 2017 v8binding: Fix NativeValueTraitsImplTest.IDLCallbackFunction in official builds. Official builds strip CHECK strings and we cannot test CHECK's message in a unittest. This patch relaxes the test condition so that it passes with official builds. Bug: 779820 Change-Id: Idd370898a826af87876c2c1988b5a6c208fa6378 Reviewed-on: https://chromium-review.googlesource.com/745803 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#512811} [modify] https://crrev.com/df74852f8236bf42e0f2e2a0895e69d535fee45d/third_party/WebKit/Source/bindings/core/v8/NativeValueTraitsImplTest.cpp
,
Nov 1 2017
,
Dec 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56ac131bf1ea1646cc0b71081a92647151bf6ce2 commit 56ac131bf1ea1646cc0b71081a92647151bf6ce2 Author: Wez <wez@chromium.org> Date: Tue Dec 05 22:03:49 2017 Fix webkit_unit_tests target to build under Fuchsia. This requires fixing NativeValueTraitsImplTest.IDLCallbackFunction to use ASSERT_DEATH_IF_SUPPORTED. The conditional handling for Official vs normal builds is also removed, for simplicity. Bug: 779820 , 707031 Change-Id: Ib2563d8b6ca792ce916d7be907956d33329e4ba4 Reviewed-on: https://chromium-review.googlesource.com/802355 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#521849} [modify] https://crrev.com/56ac131bf1ea1646cc0b71081a92647151bf6ce2/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/56ac131bf1ea1646cc0b71081a92647151bf6ce2/testing/buildbot/chromium.linux.json [modify] https://crrev.com/56ac131bf1ea1646cc0b71081a92647151bf6ce2/testing/buildbot/waterfalls.pyl [modify] https://crrev.com/56ac131bf1ea1646cc0b71081a92647151bf6ce2/third_party/WebKit/Source/bindings/core/v8/NativeValueTraitsImplTest.cpp [modify] https://crrev.com/56ac131bf1ea1646cc0b71081a92647151bf6ce2/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by thakis@chromium.org
, Oct 30 2017