New issue
Advanced search Search tips

Issue 779727 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 654131



Sign in to add a comment

report graphics_Drm subtest results to wmatrix/goldeneye/cros-perf

Project Member Reported by gurcheta...@chromium.org, Oct 30 2017

Issue description

Looking at the graphics_Drm results:

https://wmatrix.googleplex.com/failures/graphics?tests=graphics_Drm

it looks like the atomictest is running on coral, winky, clapper.  It should only run on v4.4 boards or higher (kevin, eve, bob etc.)

It addition, the subtest doesn't seem to report results to wmatrix/goldeneye/cros-perf.  For example, take a look at the differences between:

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/testDetails?testName=graphics_Drm

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/testDetails?testName=graphics_Drm.bvt

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/testDetails?testName=graphics_Drm.atomictest

I can confirm the atomictest did not run completely on Kevin until very recently, but cros-perf doesn't report that:

https://chromeperf.appspot.com/report?sid=26aa28cbaed816d914712c76d633960f38352cf4aa6ddf3affe3671e8ab4092a&start_rev=31560000974400000&end_rev=32530001008100000

Ideally, we would have a graphics_Drm.atomictest failures graph, but cros-perf doesn't give that option.  pwang@, can you take a look?
 
Owner: pwang@chromium.org
Status: (was: pwangchromium.org)

Comment 2 by pwang@chromium.org, Oct 30 2017

I checked into one of the winky/clapper DUT used in testing. 
(chromeos4-row3-rack12-host14/chromeos4-row4-rack4-host14) 

(winky) localhost ~ # uname -r
4.4.92-11992-gf84ed6fd3fc1

(clapper) localhost ~ # uname -r
4.4.92-11992-gf84ed6fd3fc1

Darn ... the baytrails were converted to v4.4 a few months ago.  Let's not test them, since that moving them to v4.4 was a bad idea in the first place.

Comment 4 by pwang@chromium.org, Oct 30 2017

For the chromeperf, we are not reporting subtests other than drm_cursor_test, linear_bo_test, null_platform_test, swrast_test (subtests defined in graphics_Drm.bvt). 

We should add this to the list of reporting subtests if the test is stable enough.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/906a907165802e25b0b2fdc636364cdfbbfd9450

commit 906a907165802e25b0b2fdc636364cdfbbfd9450
Author: Gurchetan Singh <gurchetansingh@chromium.org>
Date: Sat Nov 18 06:34:32 2017

graphics_Drm: don't run atomictest on Baytrails

We enabled drm_atomic on the kabylake and rk3399 overlays. The
baytrails have issues which we don't want to fix.

BUG= chromium:779727 
TEST=test_that -b {BOARD} {IP} graphics_Drm

Change-Id: If33af16cac36f66a4a82a2dff8c867aa9341819b
Reviewed-on: https://chromium-review.googlesource.com/778079
Commit-Ready: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Po-Hsien Wang <pwang@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/906a907165802e25b0b2fdc636364cdfbbfd9450/client/site_tests/graphics_Drm/graphics_Drm.py

Blocking: 654131
Summary: report graphics_Drm subtest results to wmatrix/goldeneye/cros-perf (was: atomictest runs on platform where it shouldn't...)
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0349737150453233e130e0ffe5f7de3272aa70ae

commit 0349737150453233e130e0ffe5f7de3272aa70ae
Author: Po-Hsien Wang <pwang@chromium.org>
Date: Thu Dec 14 04:10:14 2017

GraphicsTest: Report subtest failures to chromeperf

Tests such as graphics_Drm has mulitple subtests resides within it, eg. atomictest, ...etc.
It is better to report test failure with fine grain signals.

Before:
    graphics_Drm/Failures

After:
    graphics_Drm/Failures
    graphics_Drm/Failures/null_platform_test
    graphics_Drm/Failures/drm_cursor_test
    ...

All other tests are unaffected.

BUG= chromium:779727 
TEST=test_that cave graphics_Drm.bvt
     test_that cave graphics_WebGLAquarium

Change-Id: I195feae09eadf987e5bf96985803bab266a53c3a
Reviewed-on: https://chromium-review.googlesource.com/821552
Commit-Ready: Po-Hsien Wang <pwang@chromium.org>
Tested-by: Po-Hsien Wang <pwang@chromium.org>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>

[modify] https://crrev.com/0349737150453233e130e0ffe5f7de3272aa70ae/client/site_tests/graphics_Drm/graphics_Drm.py
[modify] https://crrev.com/0349737150453233e130e0ffe5f7de3272aa70ae/client/cros/graphics/graphics_utils.py

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b23777444fe66ddf629fd540eb2ad70a732f00ec

commit b23777444fe66ddf629fd540eb2ad70a732f00ec
Author: Po-Hsien Wang <pwang@chromium.org>
Date: Thu Dec 14 04:10:22 2017

graphics_Drm: Report all subtests to chromeperf.

Instead of just reporting graphics_Drm.bvt to chromeperf, report all the
supported subtests of graphics_Drm to chromeperf.

BUG= chromium:779727 
TEST=test_that graphics_Drm.atomictest

Change-Id: I4c459aed10bf479a4585cce727c94e27d237138a
Reviewed-on: https://chromium-review.googlesource.com/821553
Commit-Ready: Po-Hsien Wang <pwang@chromium.org>
Tested-by: Po-Hsien Wang <pwang@chromium.org>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>

[modify] https://crrev.com/b23777444fe66ddf629fd540eb2ad70a732f00ec/client/site_tests/graphics_Drm/control.bvt
[modify] https://crrev.com/b23777444fe66ddf629fd540eb2ad70a732f00ec/client/site_tests/graphics_Drm/control

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/de55727980ec4521453e10948478724ec9dba906

commit de55727980ec4521453e10948478724ec9dba906
Author: Ilja H. Friedel <ihf@chromium.org>
Date: Fri Dec 15 08:35:29 2017

Revert "GraphicsTest: Report subtest failures to chromeperf"

This reverts commit 0349737150453233e130e0ffe5f7de3272aa70ae.

Speculative revert for graphics_dEQP alerts.

BUG= chromium:779727 

Change-Id: I6d9df776696151d471cee6c844aecd4c1c426b47
Reviewed-on: https://chromium-review.googlesource.com/828525
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/de55727980ec4521453e10948478724ec9dba906/client/site_tests/graphics_Drm/graphics_Drm.py
[modify] https://crrev.com/de55727980ec4521453e10948478724ec9dba906/client/cros/graphics/graphics_utils.py

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e83f6eac03b74c4442f4defbe2370ccdb6fe2928

commit e83f6eac03b74c4442f4defbe2370ccdb6fe2928
Author: Po-Hsien Wang <pwang@chromium.org>
Date: Tue Dec 19 04:33:10 2017

GraphicsTest: Report subtest failures to chromeperf

Tests such as graphics_Drm has mulitple subtests resides within it, eg. atomictest, ...etc.
It is better to report test failure with fine grain signals.

Before:
    graphics_Drm/Failures

After:
    graphics_Drm/Failures
    graphics_Drm/Failures/null_platform_test
    graphics_Drm/Failures/drm_cursor_test
    ...

All other tests are unaffected.

BUG= chromium:779727 
TEST=test_that DUT graphics_Drm.bvt
     test_that DUT graphics_WebGLAquarium
     test_that DUT graphics_dEQP.gles2-master.hasty.0
     test_that DUT graphics_dEQP.gles2-master
     and check results' Failure & Timeout_Reboot value

Change-Id: Id218315615449dea6182e8e26c12978f088b2b16
Reviewed-on: https://chromium-review.googlesource.com/830906
Commit-Ready: Po-Hsien Wang <pwang@chromium.org>
Tested-by: Po-Hsien Wang <pwang@chromium.org>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>

[modify] https://crrev.com/e83f6eac03b74c4442f4defbe2370ccdb6fe2928/client/site_tests/graphics_Drm/graphics_Drm.py
[modify] https://crrev.com/e83f6eac03b74c4442f4defbe2370ccdb6fe2928/client/cros/graphics/graphics_utils.py

Comment 11 by pwang@chromium.org, Dec 19 2017

The recent graphics_Drm vgem_test failure from 
https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICQ8LCtsgoM
verified that commit 0349737150453233e130e0ffe5f7de3272aa70ae works.

Would wait to see if the relanded e83f6eac03b74c4442f4defbe2370ccdb6fe2928 generates any false alerts.

Comment 12 by pwang@chromium.org, Feb 23 2018

Status: Verified
No false alert is generated. Mark as verified.

Sign in to add a comment