New issue
Advanced search Search tips

Issue 779718 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

When using Swarming raw command, ignore relative_cwd

Project Member Reported by mar...@chromium.org, Oct 30 2017

Issue description

- Archival: Do not set relative_cwd in the isolated file if no command was set.
- Execution: Do not use relative_cwd from the isolated file unless a command was set.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/57c9128d5a407eb77d98545bd01dcf77c8e9dd29

commit 57c9128d5a407eb77d98545bd01dcf77c8e9dd29
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Mon Oct 30 21:56:28 2017

Do not specify relative_cwd unless a command is also specified

This is to make the processing of Swarming task with a raw command not have
interference from the isolated file.

R=vadimsh@chromium.org
Bug:  779718 
Change-Id: Ic041c794bb2b4d29fed6a7b8f681ecf03bc8a6f6
Reviewed-on: https://chromium-review.googlesource.com/744704
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/57c9128d5a407eb77d98545bd01dcf77c8e9dd29/client/isolate/isolate.go

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/17cdec8d2328e6a55688ecddd2eaade6dfbfca06

commit 17cdec8d2328e6a55688ecddd2eaade6dfbfca06
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Tue Oct 31 14:57:23 2017

run_isolated: ignore relative_cwd if isolated's command is not used.

Do not specify relative_cwd unless a command is also specified

This is to make the processing of Swarming task with a raw command not have
interference from the isolated file.

R=vadimsh@chromium.org
Bug:  779718 
Change-Id: I7f65d14a7586fc24e45b3edc9d5062b9861fbb9e
Reviewed-on: https://chromium-review.googlesource.com/744921
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/17cdec8d2328e6a55688ecddd2eaade6dfbfca06/client/isolate.py
[modify] https://crrev.com/17cdec8d2328e6a55688ecddd2eaade6dfbfca06/client/run_isolated.py
[modify] https://crrev.com/17cdec8d2328e6a55688ecddd2eaade6dfbfca06/client/tests/isolate_smoke_test.py
[modify] https://crrev.com/17cdec8d2328e6a55688ecddd2eaade6dfbfca06/client/tests/isolate_test.py

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf7bb4c0073812d7b961965b2be8c888bc21eddd

commit cf7bb4c0073812d7b961965b2be8c888bc21eddd
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Wed Nov 01 21:07:07 2017

Roll src/tools/swarming_client/ fe94e7274..5da404cf3 (5 commits)

https://chromium.googlesource.com/infra/luci/client-py.git/+log/fe94e7274e40..5da404cf35b6

$ git log fe94e7274..5da404cf3 --date=short --no-merges --format='%ad %ae %s'
2017-10-31 maruel Remove code that should have been deleted 3 years ago.
2017-10-31 maruel run_isolated: ignore relative_cwd if isolated's command is not used.
2017-10-30 maruel client: throw if the response is corrupted.
2017-10-27 maruel Do not run tests (and most tests) on upload anymore
2017-10-27 maruel Print more information in case of failure

Created with:
  roll-dep src/tools/swarming_client

-> Feel free to revert if anything goes wrong <-

TBR=vadimsh@chromium.org

Bug:  779718 
Change-Id: Id21c679bdee0cd48af58d96a7558759297a9fa9e
Reviewed-on: https://chromium-review.googlesource.com/749583
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513268}
[modify] https://crrev.com/cf7bb4c0073812d7b961965b2be8c888bc21eddd/DEPS

Status: Fixed (was: Assigned)
Commit https://chromium-review.googlesource.com/749522 was also related to this change.

Sign in to add a comment