New issue
Advanced search Search tips

Issue 779716 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

MissingOverride warnings in WebView glue layer

Project Member Reported by ntfschr@chromium.org, Oct 30 2017

Issue description

It looks like the glue layer produces new compile warnings due to errorprone:

../../android_webview/glue/java/src/com/android/webview/chromium/ContentSettingsAdapter.java:614: warning: [MissingOverride] setDisabledActionModeMenuItems implements method in WebSettings; expected @Override
    public void setDisabledActionModeMenuItems(int menuItems) {
                ^
    (see http://errorprone.info/bugpattern/MissingOverride)
  Did you mean '@Override public void setDisabledActionModeMenuItems(int menuItems) {'?
../../android_webview/glue/java/src/com/android/webview/chromium/ContentSettingsAdapter.java:618: warning: [MissingOverride] getDisabledActionModeMenuItems implements method in WebSettings; expected @Override
    public int getDisabledActionModeMenuItems() {
               ^
    (see http://errorprone.info/bugpattern/MissingOverride)
  Did you mean '@Override public int getDisabledActionModeMenuItems() {'?
../../android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java:690: warning: [MissingOverride] getTokenBindingService implements method in WebViewFactoryProvider; expected @Override
    public TokenBindingService getTokenBindingService() {
                               ^
    (see http://errorprone.info/bugpattern/MissingOverride)
  Did you mean '@Override public TokenBindingService getTokenBindingService() {'?
../../android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java:300: warning: [MissingOverride] isRedirect implements method in WebResourceRequest; expected @Override
        public boolean isRedirect() {
                       ^
    (see http://errorprone.info/bugpattern/MissingOverride)
  Did you mean '@Override public boolean isRedirect() {'?


... (and many more) ...



-----



I think we can just add the appropriate @Override annotations.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4eff04aae6ac9d52883d3a3409c28b197924a789

commit 4eff04aae6ac9d52883d3a3409c28b197924a789
Author: Nate Fischer <ntfschr@chromium.org>
Date: Wed Nov 01 02:38:09 2017

AW: add @Override to fix compile warnings in glue layer

No change in logic.

This adds @Override annotations to fix compile warnings in WebView's
glue layer.

Bug:  779716 
Test: ninja system_webview_google_apk (rebuild glue, look for compile warnings)
Change-Id: I73096eaec795a9956993ed34f7d1508c0d19e01f
Reviewed-on: https://chromium-review.googlesource.com/744962
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513050}
[modify] https://crrev.com/4eff04aae6ac9d52883d3a3409c28b197924a789/android_webview/glue/java/src/com/android/webview/chromium/ContentSettingsAdapter.java
[modify] https://crrev.com/4eff04aae6ac9d52883d3a3409c28b197924a789/android_webview/glue/java/src/com/android/webview/chromium/ServiceWorkerClientAdapter.java
[modify] https://crrev.com/4eff04aae6ac9d52883d3a3409c28b197924a789/android_webview/glue/java/src/com/android/webview/chromium/WebMessagePortAdapter.java
[modify] https://crrev.com/4eff04aae6ac9d52883d3a3409c28b197924a789/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
[modify] https://crrev.com/4eff04aae6ac9d52883d3a3409c28b197924a789/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
[modify] https://crrev.com/4eff04aae6ac9d52883d3a3409c28b197924a789/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Bulk edit: marking stale 'fixed' bugs as 'verified' since they don't need verification at this point.

Sign in to add a comment