New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 779661 link

Starred by 0 users
Status: Fixed
Owner:
█ jamwalla@chromium.org
Last visit > 30 days ago
Closed: Dec 2017
Cc:
paulmiller@chromium.org
ntfschr@chromium.org
changwan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Add metrics to LoadDataWithBaseUrl

Project Member Reported by jamwalla@chromium.org, Oct 30 2017 
We'll add a histogram to count the different ways that the baseUrl and historyUrl parameters are used.
In particular, we want to see how often historyUrl is:
-null / empty string
-the same as baseUrl
-different from baseUrl

We can use these results to decide if historyUrl should be deprecated, as discussed in crbug.com/669885. See also crbug.com/778422 about adding call counters to WebView APIs.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c36968db22c771080854a5be9e48ee12b412fcdb

commit c36968db22c771080854a5be9e48ee12b412fcdb
Author: James Wallace-Lee <jamwalla@chromium.org>
Date: Mon Dec 04 20:26:01 2017

WebView: UMA metric for LoadDataWithBaseUrl historyUrl parameter

This CL adds a histogram to track how often loadDataWithBaseUrl is
called with a historyUrl parameter that is empty, the same as
baseUrl, or different from baseUrl.

Bug:  779661 
Change-Id: Ifba359d6527454cedf4879990c8ce73f7e0225ef
Reviewed-on: https://chromium-review.googlesource.com/798354
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521429}
[modify] https://crrev.com/c36968db22c771080854a5be9e48ee12b412fcdb/android_webview/java/src/org/chromium/android_webview/AwContents.java
[modify] https://crrev.com/c36968db22c771080854a5be9e48ee12b412fcdb/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/c36968db22c771080854a5be9e48ee12b412fcdb/tools/metrics/histograms/histograms.xml

Comment 2 by jamwalla@chromium.org, Dec 4 2017

Status: Fixed (was: Assigned)
The histogram is called WebView.LoadDataWithBaseUrl.HistoryUrl. We'll use this to move forward with crbug.com/669885.
►

Sign in to add a comment