New issue
Advanced search Search tips

Issue 779633 link

Starred by 3 users

Issue metadata

Status: Fixed
Merged: issue 764932
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Some web pages are blocked by iPhoneX notch

Project Member Reported by pkl@chromium.org, Oct 30 2017

Issue description

Using a ToT build, the left side of web pages are obscured by the camera shelf (notch) when device is held in landscape mode.
 
apple.png
245 KB View Download
espn.png
937 KB View Download
bild.png
1.1 MB View Download

Comment 1 by pkl@chromium.org, Oct 30 2017

Cc: gambard@chromium.org pinkerton@chromium.org
Components: Mobile>WebView>Glue
Labels: -Pri-2 ReleaseBlock-Stable M-63 Pri-1
Owner: eugene...@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by pkl@chromium.org, Oct 30 2017

One more example.
nytimes.png
243 KB View Download
Components: -Mobile>WebView>Glue UI>Browser>Core
Mergedinto: 764932
Status: Duplicate (was: Assigned)
Per  crbug.com/764932  we need to use proper NSLayoutConstraints for web content view.

Comment 4 by pkl@chromium.org, Oct 31 2017

Status: Assigned (was: Duplicate)
This may be unrelated to  issue 764932 .
From Tip of Tree, the web view is too wide. M63 branch works fine. Some changes post-branch broke this. The state of Safe Area Compatible Toolbar does not affect this.
Owner: pkl@chromium.org
pkl@ could you please find a different owner for this bug, which is not related to web.
pkl@: If this is fine on M63, why is it a M63 RBS? Should we update the labels?

Comment 7 by pkl@chromium.org, Oct 31 2017

Labels: -M-63 M-64
Moved to M64 RBS.

Comment 8 by pkl@chromium.org, Nov 8 2017

Cc: justincohen@chromium.org
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b4d0b16848c1a4fce0f6700517e21793513930b

commit 6b4d0b16848c1a4fce0f6700517e21793513930b
Author: Justin Cohen <justincohen@chromium.org>
Date: Wed Nov 08 18:13:06 2017

Revert "Set WKScrollView.contentInsetAdjustmentBehavior to |never|"

This reverts commit 47291533062266de1a00c8f3802929b929462867.

Reason for revert: Breaks iPhone X insets.

Original change's description:
> Set WKScrollView.contentInsetAdjustmentBehavior to |never|
>
> This is required for //ios/web_view (crbug.com/774876).
>
> TEST=Fullscreen and overscroll actions
>
> Bug: 774876
> Change-Id: Ie6c57ea5efd2d7fc6d8f26117db07171c085ad69
> Reviewed-on: https://chromium-review.googlesource.com/720856
> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#509259}

TBR=eugenebut@chromium.org,ichikawa@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

TBR=ichikawa, eugenebut

Bug: 774876,  779633 
Change-Id: Ib284bb71e21b5655a98c6e45ab88b988ac504139
Reviewed-on: https://chromium-review.googlesource.com/758976
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514882}
[modify] https://crrev.com/6b4d0b16848c1a4fce0f6700517e21793513930b/ios/web/web_state/web_view_internal_creation_util.mm

Status: Fixed (was: Assigned)
This may impact clients of ios/web. I sent an email. 
Status: Assigned (was: Fixed)
I can still see the same behavior with apple.com, bild.de websites on M64 with iPhoneX. Please see the attached video.
espn.com loaded fine.
Peter, any update?

Comment 15 by cmasso@google.com, Jan 9 2018

Cc: -justincohen@chromium.org pkl@chromium.org
Owner: justincohen@chromium.org
Assigning to Justin. Please take a look!
Labels: -ReleaseBlock-Stable Hotlist-Radar-Filed
Status: ExternalDependency (was: Assigned)
I can reproduce this in a sample WKWebView app.  Firefox on iOS and Edge on iOS both seem to have the same problem.  Filed https://bugreport.apple.com/web/?problemID=36380140


Thanks Justin!
 Issue 800744  has been merged into this issue.
Cc: srikanthg@chromium.org
The radar I filed still reproduces, but it seems like the matching bug in Chrome no longer reproduces in 11.3.  I think we should mark this bug fixed, but leave the radar open.  srikanthg@ what do you think -- can you confirm?
I verified the websites that are originally reported and few other websites (News sites) and websites seems tobe loading fine. Its safe to close this bug Fixed.

Tested on iPhoneX, iOS11.3 beta#2, M64,65
Status: Fixed (was: ExternalDependency)
Reproduced for me on X (iOS 11.2.5)
Chrome 64
Also reproduced if tap on some elements on page e.g. menu.
Also reproduced on Chrome 65.
Hi oleksandr.pelykh@, can you provide more details on what are seeing? 
The behavior is the same as in bug descriptions. On the same websites.
These issues are fixed on iOS11.3 and above. Can you please try with the latest iOS11.3 and M66 Chrome and see if this is still happening?
Fixed. Thanks.

Sign in to add a comment