Issue metadata
Sign in to add a comment
|
Some web pages are blocked by iPhoneX notch |
||||||||||||||||||||||||
Issue descriptionUsing a ToT build, the left side of web pages are obscured by the camera shelf (notch) when device is held in landscape mode.
,
Oct 30 2017
One more example.
,
Oct 30 2017
Per crbug.com/764932 we need to use proper NSLayoutConstraints for web content view.
,
Oct 31 2017
This may be unrelated to issue 764932 . From Tip of Tree, the web view is too wide. M63 branch works fine. Some changes post-branch broke this. The state of Safe Area Compatible Toolbar does not affect this.
,
Oct 31 2017
pkl@ could you please find a different owner for this bug, which is not related to web.
,
Oct 31 2017
pkl@: If this is fine on M63, why is it a M63 RBS? Should we update the labels?
,
Oct 31 2017
Moved to M64 RBS.
,
Nov 8 2017
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b4d0b16848c1a4fce0f6700517e21793513930b commit 6b4d0b16848c1a4fce0f6700517e21793513930b Author: Justin Cohen <justincohen@chromium.org> Date: Wed Nov 08 18:13:06 2017 Revert "Set WKScrollView.contentInsetAdjustmentBehavior to |never|" This reverts commit 47291533062266de1a00c8f3802929b929462867. Reason for revert: Breaks iPhone X insets. Original change's description: > Set WKScrollView.contentInsetAdjustmentBehavior to |never| > > This is required for //ios/web_view (crbug.com/774876). > > TEST=Fullscreen and overscroll actions > > Bug: 774876 > Change-Id: Ie6c57ea5efd2d7fc6d8f26117db07171c085ad69 > Reviewed-on: https://chromium-review.googlesource.com/720856 > Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509259} TBR=eugenebut@chromium.org,ichikawa@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. TBR=ichikawa, eugenebut Bug: 774876, 779633 Change-Id: Ib284bb71e21b5655a98c6e45ab88b988ac504139 Reviewed-on: https://chromium-review.googlesource.com/758976 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#514882} [modify] https://crrev.com/6b4d0b16848c1a4fce0f6700517e21793513930b/ios/web/web_state/web_view_internal_creation_util.mm
,
Nov 8 2017
,
Nov 10 2017
This may impact clients of ios/web. I sent an email.
,
Jan 6 2018
,
Jan 9 2018
Peter, any update?
,
Jan 9 2018
Assigning to Justin. Please take a look!
,
Jan 9 2018
I can reproduce this in a sample WKWebView app. Firefox on iOS and Edge on iOS both seem to have the same problem. Filed https://bugreport.apple.com/web/?problemID=36380140
,
Jan 9 2018
Thanks Justin!
,
Jan 11 2018
Issue 800744 has been merged into this issue.
,
Feb 14 2018
The radar I filed still reproduces, but it seems like the matching bug in Chrome no longer reproduces in 11.3. I think we should mark this bug fixed, but leave the radar open. srikanthg@ what do you think -- can you confirm?
,
Feb 14 2018
I verified the websites that are originally reported and few other websites (News sites) and websites seems tobe loading fine. Its safe to close this bug Fixed. Tested on iPhoneX, iOS11.3 beta#2, M64,65
,
Feb 14 2018
,
Feb 16 2018
Reproduced for me on X (iOS 11.2.5) Chrome 64
,
Feb 16 2018
Also reproduced if tap on some elements on page e.g. menu.
,
Feb 16 2018
Also reproduced on Chrome 65.
,
Apr 16 2018
Hi oleksandr.pelykh@, can you provide more details on what are seeing?
,
Apr 24 2018
The behavior is the same as in bug descriptions. On the same websites.
,
Apr 24 2018
These issues are fixed on iOS11.3 and above. Can you please try with the latest iOS11.3 and M66 Chrome and see if this is still happening?
,
Jun 12 2018
Fixed. Thanks. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by pkl@chromium.org
, Oct 30 2017Components: Mobile>WebView>Glue
Labels: -Pri-2 ReleaseBlock-Stable M-63 Pri-1
Owner: eugene...@chromium.org
Status: Assigned (was: Untriaged)