New issue
Advanced search Search tips

Issue 779628 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

cros tryjob help shows incorrect usage

Project Member Reported by davidri...@chromium.org, Oct 30 2017

Issue description

cros tryjob -h shows:
  cros tryjob -g 123 -g 456 lumpy-compile-only-pre-cq daisy-pre-cq

But the correct syntax is:
  cros tryjob -g "123 456" XYZ

Ideally support -g 123 -g 456, -g "123,456" and -g "123 456", but at a minimum fix help text.
 
We support all of those already, except maybe the "123,456".

I'd never even heard of -g "123 456" until I wrote the new command. I'd prefer to remove it since it's a weird syntax, but there seem to be a lot of people using it.

Status: WontFix (was: Untriaged)
-g 123 -g 456 does not work.
Here's an example build spawned with cros tryjob -g 744284 -g 742205 cyan-no-vmtest-pre-cq cyan-paladin
https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/paladin/builds/4141
Status: Unconfirmed (was: WontFix)
Here's the real world test which shows otherwise:
➜ cros tryjob -g 744284 -g 742205 cyan-no-vmtest-pre-cq cyan-paladin
Verifying patches...
Submitting tryjob...
Successfully sent PUT request to [buildbucket_bucket:master.chromiumos.tryserver] with [config:cyan-no-vmtest-pre-cq] [buildbucket_id:8964288791307500512].
Successfully sent PUT request to [buildbucket_bucket:master.chromiumos.tryserver] with [config:cyan-paladin] [buildbucket_id:8964288791018213168].
Tryjob submitted!
To view your tryjobs, visit:
  https://uberchromegw.corp.google.com/i/chromiumos.tryserver/waterfall?committer=davidriley@chromium.org&builder=no_vmtest_pre_cq&builder=paladin
Status: WontFix (was: Unconfirmed)
Sigh, I'm an idiot.  Too many invocations and matched the wrong build.
I dislike the way we group tryjobs today. It's awkward and painful. The only good news is that we have a plan to fix it. It's just currently blocked on CrOps.

I've been talking about them to try and get it prioritized. Working on an email to collected assorted discussions together right now.

Sign in to add a comment