New issue
Advanced search Search tips

Issue 779594 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Drop module build for alt-syscall

Project Member Reported by groeck@chromium.org, Oct 30 2017

Issue description

alt-syscall supports building it as module, but we don't use it, and the modular code is buggy and would not work in reality (the code uses #ifdef CONFIG_ALT_SYSCALL, which is not defined for module builds).
On top of that, building it as module requires exporting various syscall entry points, which adds lots of private changes into the kernel.
Let's just drop modular builds and always build it into the kernel.


 

Comment 1 by groeck@chromium.org, Oct 30 2017

Status: WontFix (was: Assigned)
... turns out this change was already made, so all we need to do is to remove all the additional EXPORTs which are no longer needed. We'll do this in the chromeos-4.14 rebase.

Comment 2 by groeck@chromium.org, Oct 30 2017

Status: Assigned (was: WontFix)
Umm ... not really. There is also ALT_SYSCALL_CHROMIUMOS which can be built as module.

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 31 2017

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/3585beefc72b10ab48e6df4db4ddab4d73b32510

commit 3585beefc72b10ab48e6df4db4ddab4d73b32510
Author: Guenter Roeck <groeck@chromium.org>
Date: Tue Oct 31 01:47:45 2017

security: Drop modular build for ALT_SYSCALL_CHROMIUMOS

Building ALT_SYSCALL_CHROMIUMOS as module isn't used, and only results
in having to export lots of syscall entry points.

BUG= chromium:779594 
TEST=Build test image and ensure functionality is still there

Change-Id: Ifa4aa43217efabb4b5a4b8968449d55065b9992c
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/744121
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/3585beefc72b10ab48e6df4db4ddab4d73b32510/security/chromiumos/Kconfig

Comment 4 by groeck@chromium.org, Oct 31 2017

Status: Fixed (was: Assigned)

Sign in to add a comment