New issue
Advanced search Search tips

Issue 779593 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jan 21
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Track Proguard Flags in Supersize

Project Member Reported by agrieve@chromium.org, Oct 30 2017

Issue description

Related to tracking java, it would useful to record proguard flags in .size files, so that it's easy to diff them. 

E.g. when we do support library rolls, it would be nice if diagnose_bloat.py would show the proguard flags that changed. 

Reason to add this to .size rather than in diagnose_bloat.py, is that .size files are meant to archive size information, and this is information that's worth archiving IMO.

proguard flags that were used can be found here:
gen/chrome/android/chrome_public_apk/chrome_public_apk.proguard.jar.flags

The format of the file is custom to our build system, so we can change it to be more parsable. May want to strip comments to make it smaller & more diffable.

Probably this information would go well on SizeInfo.proguard_flags, and should be surfaced in Diffs().
 
Project Member

Comment 1 by sheriffbot@chromium.org, Oct 31

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by estevenson@chromium.org, Jan 21 (2 days ago)

Status: WontFix (was: Untriaged)
We now track proguard flags in the source tree, so no need to do this

Sign in to add a comment