New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 779592 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 773754



Sign in to add a comment

Disable voice search while in incognito

Project Member Reported by bshe@chromium.org, Oct 30 2017

Issue description

voice search should be disabled while in incognito mode. 2D chrome did the same.
 

Comment 1 by bshe@chromium.org, Oct 31 2017

Owner: vollick@chromium.org
per meeting today, assign to vollick. Thanks for help.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41a2423f92282893c9a3ac4fc4e57ce2c045e9ed

commit 41a2423f92282893c9a3ac4fc4e57ce2c045e9ed
Author: Ian Vollick <vollick@chromium.org>
Date: Wed Nov 01 20:04:03 2017

[vr] Hide the voice search button in incognito mode

With this change, the voice search button is disabled via binding when
we are in incognito mode. Additionally, we store a bit on the model for
when we've got experimental VR features enabled so that it may more
easily be bound and toggled in tests. This also means that the ui scene
manager no longer needs to retain a pointer to the voice search button.
Further, we no longer add the button to control_elements_ since it will
inherit the visibility of the URL bar due to being in its subtree.

Bug:  779592 
Change-Id: I92832f46b4cdf33e7a9caf57076001a24ff9ab83
Reviewed-on: https://chromium-review.googlesource.com/748774
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513233}
[modify] https://crrev.com/41a2423f92282893c9a3ac4fc4e57ce2c045e9ed/chrome/browser/vr/model/model.h
[modify] https://crrev.com/41a2423f92282893c9a3ac4fc4e57ce2c045e9ed/chrome/browser/vr/test/ui_scene_manager_test.cc
[modify] https://crrev.com/41a2423f92282893c9a3ac4fc4e57ce2c045e9ed/chrome/browser/vr/test/ui_scene_manager_test.h
[modify] https://crrev.com/41a2423f92282893c9a3ac4fc4e57ce2c045e9ed/chrome/browser/vr/ui.cc
[modify] https://crrev.com/41a2423f92282893c9a3ac4fc4e57ce2c045e9ed/chrome/browser/vr/ui_scene_manager.cc
[modify] https://crrev.com/41a2423f92282893c9a3ac4fc4e57ce2c045e9ed/chrome/browser/vr/ui_scene_manager.h
[modify] https://crrev.com/41a2423f92282893c9a3ac4fc4e57ce2c045e9ed/chrome/browser/vr/ui_scene_manager_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment