New issue
Advanced search Search tips

Issue 779591 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: ----
Type: ----



Sign in to add a comment

Clean up Printer Selection Dialog in Chrome UI

Project Member Reported by weifangsun@chromium.org, Oct 30 2017

Issue description

Currently, when a user goes to print -> Change Destination, the Printer Selection Dialog which appears can be confusing with 3 different sections and replication of the available printers.

We should simplify this UI to facilitate user selection of the relevant printer.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e91723a42b90b849faccc93d333d0c7c867e4ad8

commit e91723a42b90b849faccc93d333d0c7c867e4ad8
Author: xdai <xdai@chromium.org>
Date: Tue Nov 21 19:32:54 2017

Print preview: Chrome printer selection dialog update

See
https://docs.google.com/presentation/d/13_Hgj3GPIjXG7RKspRpOAg-GiQ1TSCOjkBmuU979g9E/edit#slide=id.g2702f89868_0_0
for proposed change:
- Combine Local Destinations and Google Cloud Destinations to Print Destinations
- Click on the "Manage..." link will direct the user to Chrome Print settings page
- Add one row "Printers" under the "Printing" section of Chrome settings page on
  operation systems other than Chrome OS. Click on the "Printers" item will open
  the System native print dialog.

Bug:  779591 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I686719924aa956074345236be73a6cd3af44b530
Reviewed-on: https://chromium-review.googlesource.com/775578
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518333}
[modify] https://crrev.com/e91723a42b90b849faccc93d333d0c7c867e4ad8/chrome/app/generated_resources.grd
[modify] https://crrev.com/e91723a42b90b849faccc93d333d0c7c867e4ad8/chrome/app/settings_strings.grdp
[modify] https://crrev.com/e91723a42b90b849faccc93d333d0c7c867e4ad8/chrome/browser/resources/print_preview/data/destination_store.js
[modify] https://crrev.com/e91723a42b90b849faccc93d333d0c7c867e4ad8/chrome/browser/resources/print_preview/native_layer.js
[modify] https://crrev.com/e91723a42b90b849faccc93d333d0c7c867e4ad8/chrome/browser/resources/print_preview/print_preview.js
[delete] https://crrev.com/08b0819307cc7d1a973e7d938ff156527519c791/chrome/browser/resources/print_preview/search/cloud_destination_list.js
[modify] https://crrev.com/e91723a42b90b849faccc93d333d0c7c867e4ad8/chrome/browser/resources/print_preview/search/destination_search.html
[modify] https://crrev.com/e91723a42b90b849faccc93d333d0c7c867e4ad8/chrome/browser/resources/print_preview/search/destination_search.js
[modify] https://crrev.com/e91723a42b90b849faccc93d333d0c7c867e4ad8/chrome/browser/resources/settings/printing_page/compiled_resources2.gyp
[modify] https://crrev.com/e91723a42b90b849faccc93d333d0c7c867e4ad8/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js
[add] https://crrev.com/e91723a42b90b849faccc93d333d0c7c867e4ad8/chrome/browser/resources/settings/printing_page/printing_browser_proxy.html
[add] https://crrev.com/e91723a42b90b849faccc93d333d0c7c867e4ad8/chrome/browser/resources/settings/printing_page/printing_browser_proxy.js
[modify] https://crrev.com/e91723a42b90b849faccc93d333d0c7c867e4ad8/chrome/browser/resources/settings/printing_page/printing_page.html
[modify] https://crrev.com/e91723a42b90b849faccc93d333d0c7c867e4ad8/chrome/browser/resources/settings/printing_page/printing_page.js
[modify] https://crrev.com/e91723a42b90b849faccc93d333d0c7c867e4ad8/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/e91723a42b90b849faccc93d333d0c7c867e4ad8/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/e91723a42b90b849faccc93d333d0c7c867e4ad8/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://crrev.com/e91723a42b90b849faccc93d333d0c7c867e4ad8/chrome/browser/ui/webui/print_preview/print_preview_handler.h
[modify] https://crrev.com/e91723a42b90b849faccc93d333d0c7c867e4ad8/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
[modify] https://crrev.com/e91723a42b90b849faccc93d333d0c7c867e4ad8/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/e91723a42b90b849faccc93d333d0c7c867e4ad8/chrome/browser/ui/webui/settings/md_settings_ui.cc
[add] https://crrev.com/e91723a42b90b849faccc93d333d0c7c867e4ad8/chrome/browser/ui/webui/settings/printing_handler.cc
[add] https://crrev.com/e91723a42b90b849faccc93d333d0c7c867e4ad8/chrome/browser/ui/webui/settings/printing_handler.h
[modify] https://crrev.com/e91723a42b90b849faccc93d333d0c7c867e4ad8/chrome/common/webui_url_constants.cc
[modify] https://crrev.com/e91723a42b90b849faccc93d333d0c7c867e4ad8/chrome/common/webui_url_constants.h
[modify] https://crrev.com/e91723a42b90b849faccc93d333d0c7c867e4ad8/chrome/test/data/webui/print_preview/print_preview_destination_search_test.js
[modify] https://crrev.com/e91723a42b90b849faccc93d333d0c7c867e4ad8/chrome/test/data/webui/print_preview/print_preview_tests.js

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93464c3c9ec4ded67f7128301e150e057587af6f

commit 93464c3c9ec4ded67f7128301e150e057587af6f
Author: xdai <xdai@chromium.org>
Date: Tue Nov 21 20:01:58 2017

Print preview: Limit Recent destinations section to 3 printers

- The recent destinations list number is bounded by
print_preview.AppState.NUM_DESTINATIONS_.
- The Recent destinations list will be ordered from the most to the least
recent selected.

This is a followup CL of https://chromium-review.googlesource.com/c/chromium/src/+/775578.
See proposed change:
https://docs.google.com/presentation/d/13_Hgj3GPIjXG7RKspRpOAg-GiQ1TSCOjkBmuU979g9E/edit#slide=id.g2702f89868_0_0

Bug:  779591 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib1ea6d1af71199e7346335dcb20a02d698f1d8d0
Reviewed-on: https://chromium-review.googlesource.com/777703
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518346}
[modify] https://crrev.com/93464c3c9ec4ded67f7128301e150e057587af6f/chrome/browser/resources/print_preview/data/destination_store.js
[modify] https://crrev.com/93464c3c9ec4ded67f7128301e150e057587af6f/chrome/browser/resources/print_preview/search/destination_search.js

Issue 802837 has been merged into this issue.
Questions:

1) This is marked with component: Internals>Printing>CUPS and OS: Chrome, yet it is not CUPS specific work, but rather Print Preview changes. It affects all desktop platforms. Was the bug mislabeled?

2) So is this done? What work remains?

Comment 5 by x...@chromium.org, Jan 17 2018

Status: Fixed (was: Assigned)
I think the bug was mislabeled. The work is done. I forgot to update the status.

Components: -Internals>Printing>CUPS UI>Browser>PrintPreview
Labels: OS-Linux OS-Mac OS-Windows
Updating labels since we are merging issue reports about these changes into this one for tracking.

Sign in to add a comment