New issue
Advanced search Search tips

Issue 779585 link

Starred by 1 user
Status: Fixed
Owner:
wuandy@chromium.org
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

autofill should rationalize phone numbers by sections instead of by forms

Project Member Reported by wuandy@chromium.org, Oct 30 2017 
In the phone number rationalization logic of autofill, after find the fist set of fields that can compose a complete number, it will mark any new phone number fields in the same form as 'fill_only_when_focused'. 

The fields should be processed by sections instead of forms. Such that if we have a billing section and shipping section in the same form. When user highlight any field in the shipping section, shipping phone should be filled automatically without user having to focus on that field.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/423c79e1b5675cb5d963d6733f258c7beac25b80

commit 423c79e1b5675cb5d963d6733f258c7beac25b80
Author: Hui(Andy) Wu <wuandy@chromium.org>
Date: Mon Oct 30 20:04:32 2017

[Autofill] Rationalize phone number field by sections instead of by forms.

This change will change the autofill phone number rationalization to group
fields in a form into sections first, then call the rationalization logic
once per each sections.

This will allow autofill of multiple phone numbers as long as they are in
different sections(typically: billing vs shipping).

Related change: Ia7084e63cadf676fba4af72fadcec73880be5579

Bug:  779585 
Change-Id: I0224ea355836798537195852ddc44634ba813f89
Reviewed-on: https://chromium-review.googlesource.com/743688
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Hui Wu <wuandy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512588}
[modify] https://crrev.com/423c79e1b5675cb5d963d6733f258c7beac25b80/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/423c79e1b5675cb5d963d6733f258c7beac25b80/components/autofill/core/browser/form_structure_unittest.cc

Comment 2 by wuandy@chromium.org, Nov 1 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment