Chrome_Mac: Crash Report - -[ShareMenuController performShare:] |
|||
Issue descriptionreporter:rsesek@google.com crash_analysis_section:start crash_analysis_section:end Magic Signature: -[ShareMenuController performShare:] Crash link: https://crash.corp.google.com//browse?q=product.name%3D'Chrome_Mac'%20AND%20product.version%3D'64.0.3253.0'%20AND%20custom_data.ChromeCrashProto.channel%3D'canary'%20AND%20custom_data.ChromeCrashProto.ptype%3D'browser'%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D'-%5BShareMenuController%20performShare%3A%5D'%20AND%20ReportID%3D'6511119ae5605831'&sql_dialect=dremelsql&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D#3 ------------------------------------------------------------------------------- Sample Report ------------------------------------------------------------------------------- Product name: Chrome_Mac Magic Signature : -[ShareMenuController performShare:] Product Version: 64.0.3253.0 Process type: browser Report ID: 6511119ae5605831 Report Url: https://crash.corp.google.com/6511119ae5605831 Report Time: 2017-10-30T06:01:53-07:00 Upload Time: 2017-10-30T06:01:54.327-07:00 Uptime: 11000 ms CumulativeProductUptime: 0 ms OS Name: Mac OS X OS Version: 10.12.6 16G29 CPU Architecture: amd64 CPU Info: family 6 model 61 stepping 4 ------------------------------------------------------------------------------- Crashing thread: Thread index: 0. Stack Quality: 77%. Thread id: 5417041. ------------------------------------------------------------------------------- 0x00007fff7ff4e44e (AppKit + 0x003a544e) -[NSApplication _crashOnException:] 0x00007fff7ff4e381 (AppKit + 0x003a5381) -[NSApplication reportException:] 0x00007fff80024456 (AppKit + 0x0047b456) uncaughtErrorProc 0x00007fff821feff9 (CoreFoundation + 0x0018fff9) __handleUncaughtException 0x00007fff96f9a6f4 (libobjc.A.dylib + 0x000176f4) _objc_terminate() 0x00007fff96487d48 (libc++abi.dylib + 0x00022d48) std::__terminate(void (*)()) 0x00007fff964877bd (libc++abi.dylib + 0x000227bd) __cxa_throw 0x00007fff96f985b5 (libobjc.A.dylib + 0x000155b5) objc_exception_throw 0x00007fff94effa16 (UserActivity + 0x00019a16) +[UAUserActivity(Internal) checkWebpageURL:actionType:throwIfFailed:] 0x00007fff94eec850 (UserActivity + 0x00006850) -[UAUserActivity setWebpageURL:] 0x00000001134794e7 (Google Chrome Framework - share_menu_controller.mm: 184) -[ShareMenuController performShare:] 0x00007fff97ab03a6 (libsystem_trace.dylib + 0x000033a6) _os_activity_initiate_impl 0x00007fff8036d720 (AppKit + 0x007c4720) -[NSApplication(NSResponder) sendAction:to:from:] 0x0000000110a9efda (Google Chrome Framework - chrome_browser_application_mac.mm: 243) __43-[BrowserCrApplication sendAction:to:from:]_block_invoke 0x0000000110e4aa49 (Google Chrome Framework + 0x01c91a49) base::mac::CallWithEHFrame(void () block_pointer) 0x0000000110a9eeeb (Google Chrome Framework - chrome_browser_application_mac.mm: 242) -[BrowserCrApplication sendAction:to:from:] 0x00007fff7fe40665 (AppKit + 0x00297665) -[NSMenuItem _corePerformAction] 0x00007fff7fe403d1 (AppKit + 0x002973d1) -[NSCarbonMenuImpl performActionWithHighlightingForItemAtIndex:] 0x00007fff97ab03a6 (libsystem_trace.dylib + 0x000033a6) _os_activity_initiate_impl 0x00007fff7fec9954 (AppKit + 0x00320954) -[NSMenu performActionForItemAtIndex:] 0x00007fff7fec98cb (AppKit + 0x003208cb) -[NSMenu _internalPerformActionForItemAtIndex:] 0x00007fff7fec96f8 (AppKit + 0x003206f8) -[NSCarbonMenuImpl _carbonCommandProcessEvent:handlerCallRef:] 0x00007fff7fd8057f (AppKit + 0x001d757f) NSSLMMenuEventHandler 0x00007fff8162ed84 (HIToolbox + 0x00008d84) DispatchEventToHandlers(EventTargetRec*, OpaqueEventRef*, HandlerCallRec*) 0x00007fff8162dff5 (HIToolbox + 0x00007ff5) SendEventToEventTargetInternal(OpaqueEventRef*, OpaqueEventTargetRef*, HandlerCallRec*) 0x00007fff81643d13 (HIToolbox + 0x0001dd13) SendEventToEventTarget 0x00007fff816903e5 (HIToolbox + 0x0006a3e5) SendHICommandEvent(unsigned int, HICommand const*, unsigned int, unsigned int, unsigned char, void const*, OpaqueEventTargetRef*, OpaqueEventTargetRef*, OpaqueEventRef**) 0x00007fff816bb9fa (HIToolbox + 0x000959fa) SendMenuCommandWithContextAndModifiers 0x00007fff816bb9a9 (HIToolbox + 0x000959a9) SendMenuItemSelectedEvent 0x00007fff816bb87c (HIToolbox + 0x0009587c) FinishMenuSelection(SelectionData*, MenuResult*, MenuResult*) 0x00007fff816bc2b6 (HIToolbox + 0x000962b6) MenuSelectCore(MenuData*, Point, double, unsigned int, OpaqueMenuRef**, unsigned short*) 0x00007fff816bbf65 (HIToolbox + 0x00095f65) _HandleMenuSelection2 0x00007fff7fd70367 (AppKit + 0x001c7367) _NSHandleCarbonMenuEvent 0x00007fff7ffea701 (AppKit + 0x00441701) _DPSEventHandledByCarbon 0x00007fff8036b0c4 (AppKit + 0x007c20c4) -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] 0x0000000110a9eacf (Google Chrome Framework - chrome_browser_application_mac.mm: 187) __71-[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]_block_invoke 0x0000000110e4aa49 (Google Chrome Framework + 0x01c91a49) base::mac::CallWithEHFrame(void () block_pointer) 0x0000000110a9ea13 (Google Chrome Framework - chrome_browser_application_mac.mm: 186) -[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:] 0x00007fff7fbe43da (AppKit + 0x0003b3da) -[NSApplication run] 0x0000000110e5a156 (Google Chrome Framework - message_pump_mac.mm: 804) base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) 0x0000000110e58cdd (Google Chrome Framework - message_pump_mac.mm: 179) base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) 0x0000000110e7baf3 (Google Chrome Framework - run_loop.cc: 114) <name omitted> 0x0000000110aa4317 (Google Chrome Framework - chrome_browser_main.cc: 1917) ChromeBrowserMainParts::MainMessageLoopRun(int*) 0x000000010f8efb83 (Google Chrome Framework - browser_main_loop.cc: 1207) content::BrowserMainLoop::RunMainMessageLoopParts() 0x000000010f8f2c31 (Google Chrome Framework - browser_main_runner.cc: 140) content::BrowserMainRunnerImpl::Run() 0x000000010f8ec0db (Google Chrome Framework - browser_main.cc: 46) content::BrowserMain(content::MainFunctionParams const&) 0x0000000110a592be (Google Chrome Framework - content_main_runner.cc: 705) content::ContentMainRunnerImpl::Run() 0x00000001122185a7 (Google Chrome Framework - main.cc: 456) service_manager::Main(service_manager::MainParams const&) 0x0000000110a58873 (Google Chrome Framework - content_main.cc: 19) content::ContentMain(content::ContentMainParams const&) 0x000000010f1bc46e (Google Chrome Framework - chrome_main.cc: 123) ChromeMain 0x000000010f151dd3 (Google Chrome Canary + 0x00000dd3) 0x00007fff9787e234 (libdyld.dylib + 0x00005234) start 0x00007fff9787e234 (libdyld.dylib + 0x00005234) start
,
Oct 30 2017
I was mildly surprised this is actually documented! (So, whoops) I do wonder if chrome:// URLs really need to be shareable in the first place
,
Oct 30 2017
No, I don't think it makes sense for chrome:// URLs to be sharable because I don't think the browser allows external navigations to them anyways.
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17a473fcfb847dcdd4e529420a6a221e6e526253 commit 17a473fcfb847dcdd4e529420a6a221e6e526253 Author: Leonard Grey <lgrey@chromium.org> Date: Mon Oct 30 20:51:29 2017 [Mac share menu] Don't set webpageURL on user activity for non-HTTP(S) Fixing crash for now, will deal with the larger question about whether chrome:// URLs should be shareable separately. Bug: 779575 Change-Id: I756c7912bc4d9dc51ea7a893498498b652125efa Reviewed-on: https://chromium-review.googlesource.com/744505 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#512618} [modify] https://crrev.com/17a473fcfb847dcdd4e529420a6a221e6e526253/chrome/browser/ui/cocoa/share_menu_controller.mm
,
Oct 31 2017
Users experienced this crash on the following builds: Mac Canary 64.0.3253.0 - 0.26 CPM, 2 reports, 2 clients (signature -[ShareMenuController performShare:]) If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates. - Go/Fracas
,
Nov 1 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by rsesek@chromium.org
, Oct 30 2017Labels: -Restrict-View-EditIssue
Owner: lgrey@chromium.org
Status: Assigned (was: Untriaged)