New issue
Advanced search Search tips

Issue 779548 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

4.3% regression in media.mobile at 512176:512265

Project Member Reported by liberato@google.com, Oct 30 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Oct 30 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=779548

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=6a654b80cb2e8e074171c53e8041781033e49cda79804e1ae0cd85277c7f35a2


Bot(s) for this bug's original alert(s):

android-nexus6
Components: Internals>Media
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Oct 30 2017

Cc: steimel@chromium.org
Owner: steimel@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author steimel@chromium.org ===

Hi steimel@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Tommy Steimel
  Commit : 0c9e59a7d6b7f5b307791efdbb98f512f03ed750
  Date   : Fri Oct 27 18:11:08 2017
  Subject: Revert "Show sound content setting in Page Info when tab is audible on Android"

Bisect Details
  Configuration: android_nexus6_perf_bisect
  Benchmark    : media.mobile
  Metric       : memory:chrome:all_processes:reported_by_os:system_memory:proportional_resident_size_avg/video.html?src_tulip2.wav_type_audio
  Change       : 4.03% | 102020554.667 -> 106129368.667

Revision             Result                   N
chromium@512175      102020555 +- 465496      6      good
chromium@512220      102030263 +- 719514      6      good
chromium@512232      101912345 +- 471326      6      good
chromium@512235      102110350 +- 459277      6      good
chromium@512237      101958943 +- 825608      6      good
chromium@512238      106450138 +- 322220      6      bad       <--
chromium@512243      106167653 +- 198490      6      bad
chromium@512265      106129369 +- 423153      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=video.html.src.tulip2.wav.type.audio media.mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8964301014554355024


For feedback, file a bug with component Speed>Bisection
Cc: dalecur...@chromium.org mlamouri@chromium.org m...@chromium.org
Hmm so reverting the CL also causes a perf regression ¯\_(ツ)_/¯
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Oct 30 2017

 Issue 779551  has been merged into this issue.
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Oct 30 2017

 Issue 779550  has been merged into this issue.
Status: WontFix (was: Assigned)
Looks like these metrics were improved when the original CL landed, and now reverting the CL is bringing them back to the original state. There were other metrics harshly affected by the CL, so we want to have this revert CL in. Closing as WontFix
For reference, here is the perf-regression crbug that was opened when the original CL landed:  crbug.com/776172 
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Oct 30 2017

 Issue 779553  has been merged into this issue.
Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, Oct 30 2017

 Issue 779552  has been merged into this issue.
Project Member

Comment 12 by 42576172...@developer.gserviceaccount.com, Oct 30 2017

 Issue 779554  has been merged into this issue.
Project Member

Comment 13 by 42576172...@developer.gserviceaccount.com, Oct 30 2017

 Issue 779558  has been merged into this issue.
Project Member

Comment 14 by 42576172...@developer.gserviceaccount.com, Oct 30 2017

 Issue 779559  has been merged into this issue.

Sign in to add a comment