New issue
Advanced search Search tips

Issue 779543 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

46.4% regression in media.desktop at 512004:512106

Project Member Reported by liberato@google.com, Oct 30 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Oct 30 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=779543

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=1f7fe24bf549c56356ba70ca64344f2c754f77825dedcdba852b53dbaa091ec5


Bot(s) for this bug's original alert(s):

win-high-dpi
Components: Internals>Media
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Oct 30 2017

Cc: stephen....@arm.com
Owner: stephen....@arm.com
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author stephen.kyle@arm.com ===

Hi stephen.kyle@arm.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Stephen Kyle
  Commit : 75ad6852fbdd47ed60b460929b22a5247f2f2faa
  Date   : Thu Oct 26 23:13:25 2017
  Subject: tools/perf: add chromeos to platforms for smoothness.gpu_raster

Bisect Details
  Configuration: winx64_high_dpi_perf_bisect
  Benchmark    : media.desktop
  Metric       : story:power_avg/video.html?src_tulip2.ogg_type_audio
  Change       : 28.39% | 10.9137191414 -> 7.8148106877

Revision             Result                   N
chromium@512003      10.9137 +- 4.14962       6      good
chromium@512004      7.84991 +- 0.305556      6      bad       <--
chromium@512005      7.86097 +- 0.446969      9      bad
chromium@512007      7.89259 +- 0.485083      9      bad
chromium@512010      7.82314 +- 0.333569      6      bad
chromium@512016      7.91634 +- 0.953203      6      bad
chromium@512029      7.86375 +- 0.374325      6      bad
chromium@512055      7.81391 +- 0.308157      6      bad
chromium@512106      7.81481 +- 0.40904       6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=video.html.src.tulip2.ogg.type.audio media.desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8964301132673735264


For feedback, file a bug with component Speed>Bisection

Comment 5 by stephen....@arm.com, Oct 31 2017

Is this a false positive? 

I'm not sure how my patch (which adds ChromeOS as a supported platform for smoothness.gpu_rasterization.top_25_smooth) relates to the performance of media.desktop on windows.
me either, assuming the flag performs as expected.  i wouldn't be terribly surprised either way.

i started another bisect job with a wider commit range.  we'll see what happens.

the most definitive proof i can think of would be a revert of the cl for a day or two, to see if the metrics recover or not.
Labels: Performance-Media

Comment 8 by stephen....@arm.com, Mar 19 2018

Status: WontFix (was: Assigned)
Closing this, since the power issue (as seen in https://chromeperf.appspot.com/group_report?sid=1f7fe24bf549c56356ba70ca64344f2c754f77825dedcdba852b53dbaa091ec5) seemed to go away, without this patch being reverted?

Sign in to add a comment