Two identical JSType() functions in v8/src/compiler - breaks jumbo builds |
|||
Issue description
Both v8/src/compiler/operation-typer.cc and v8/src/compiler/typer.cc declare a:
Type* JSType(Type* type) {
if (type->Is(Type::Boolean())) return Type::Boolean();
if (type->Is(Type::String())) return Type::String();
if (type->Is(Type::Number())) return Type::Number();
if (type->Is(Type::Undefined())) return Type::Undefined();
if (type->Is(Type::Null())) return Type::Null();
if (type->Is(Type::Symbol())) return Type::Symbol();
if (type->Is(Type::Receiver())) return Type::Receiver(); // JS "Object"
return Type::Any();
}
If operation-typer.cc and typer.cc end up in the same jumbo unit (they don't see to do by default but they did in my local tests with jumbo_file_merge_limit=100) that will even cause a compilation failure.
I guess the best would be to find a shared place to put it, but I'm not familiar enough with the v8 src to know such a place by heart.
,
Nov 2 2017
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/fd35526f36a2de63fc83e8f71007791b923b6557 commit fd35526f36a2de63fc83e8f71007791b923b6557 Author: Benedikt Meurer <bmeurer@chromium.org> Date: Thu Nov 02 19:02:10 2017 [turbofan] Avoid duplicate JSType function. Reduce code duplication, which breaks jumbo builds. Put the StrictEqual typing rule into the OperationTyper and share the JSType function, which is also used by SameValue. Bug: chromium:779531 Change-Id: If292f319217286fd1c676be04f9de3925ed56965 Reviewed-on: https://chromium-review.googlesource.com/751665 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#49088} [modify] https://crrev.com/fd35526f36a2de63fc83e8f71007791b923b6557/src/compiler/operation-typer.cc [modify] https://crrev.com/fd35526f36a2de63fc83e8f71007791b923b6557/src/compiler/operation-typer.h [modify] https://crrev.com/fd35526f36a2de63fc83e8f71007791b923b6557/src/compiler/typer.cc
,
Nov 2 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by brat...@opera.com
, Nov 2 2017