New issue
Advanced search Search tips

Issue 779525 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Nov 2017
Cc:
maxmorin@chromium.org
oprypin@chromium.org
Components:
EstimatedDays: ----
NextAction: 2017-11-03
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

WebRTC autoroller not including git log

Project Member Reported by maxmorin@chromium.org, Oct 30 2017 
Example:
https://chromium-review.googlesource.com/c/chromium/src/+/743762
has a description like
$ git log 6bfac0383..ce5023955 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


It is expected to see the actual log under the "git log" command line.
There also isn't any link to the autoroller on the linked "Failures due to DEPS rolls" wiki page.

Comment 1 by ehmaldonado@chromium.org, Oct 30 2017 

This was intentional, since logs were long with commits:
https://cs.chromium.org/chromium/tools/depot_tools/roll_dep.py?l=61

We can take a look at the rolls for a couple of days and see if this is still causing problems.

As for the wiki page, I just updated it.

Comment 2 by ehmaldonado@chromium.org, Oct 30 2017

NextAction: 2017-11-03
I'll take a look at the rolls on Friday.

Comment 3 by monor...@bugs.chromium.org, Nov 3 2017 

The NextAction date has arrived: 2017-11-03

Comment 4 by ehmaldonado@chromium.org, Nov 3 2017

Cc: -ehmaldonado@chromium.org maxmorin@chromium.org
Status: WontFix (was: Untriaged)
Ok, there were several rolls with more than 10 commits last week [1], which would make the CL description too long.
I'm not sure how useful it'd be to display them, specially when there's a link above with the same information.

I'm inclined to mark this as Won't Fix. Please re-open if you disagree.

[1] https://chromium-review.googlesource.com/q/owner:%2522WebRTC+Roll+Bot+%253Cwebrtc-autoroll%2540chromium.org%253E%2522
►

Sign in to add a comment