Issue metadata
Sign in to add a comment
|
Regression : 'Preview picture' view and 'photo from internal camera' view are different in 'Create a new supervised user' overlay |
||||||||||||||||||||||
Issue descriptionChrome Version: 63.0.3239.26/10032.21.0 dev-channel Daisy,Reks and Candy OS: Chrome What steps will reproduce the problem? (1)In sign-out screen click on three dot Menu to 'Add supervised User' (2)Click on 'Create Supervised User' -> Now enter password in'Choose the manager for this supervised user' Overlay -> Navigates to 'Create Supervised User' overlay (3)Now at Profile pictures click on 'Take photo' option -> So that Camera screen is seen ->Press 'Enter' button and picture is captured (4)Now observe the' preview picture' view and 'photo from internal camera' view (Please refer Video and screenshot) Expected: 'Preview picture' view and 'photo from internal camera' view should be same Actual: Instead Captured picture is seen shifted to L.H.S/R.H.S i.e. 'photo from internal camera' view is different from 'Preview picture' view This is Regression issue as same is working fine in M-62 @reveman: Please confirm the issue Note : Issue is seen on latest M-64
,
Oct 30 2017
Attaching Videos and screenshots for reference and adding 'Stable' blocker as this is a recent regression ,please remove if not requires
,
Oct 30 2017
This is technically not a regression. The same would happen if using the flipped photo mode before M63 but flipped mode was not the default behavior until M63. Not sure RB label is needed for that reason but this should be easy to fix so fine to keep this label for now.
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41e6d26e78c2426341f2210f8979be3de1aa8244 commit 41e6d26e78c2426341f2210f8979be3de1aa8244 Author: David Reveman <reveman@chromium.org> Date: Mon Oct 30 18:59:16 2017 Login: Fix horizontal flip for supervised user image grid. Use flipped image instead of relying on css transform for image preview. This allows both the grid image and the image preview to be displayed correctly. Bug: 779519 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icd0fb45f1dc433d490f24d5342c250197e96c11b Reviewed-on: https://chromium-review.googlesource.com/743693 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#512564} [modify] https://crrev.com/41e6d26e78c2426341f2210f8979be3de1aa8244/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.css [modify] https://crrev.com/41e6d26e78c2426341f2210f8979be3de1aa8244/chrome/browser/resources/chromeos/user_images_grid.js
,
Oct 30 2017
,
Oct 31 2017
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 3 2017
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/105ccce69ec9f1c599bb02cb1f469e73d19ca3fd commit 105ccce69ec9f1c599bb02cb1f469e73d19ca3fd Author: David Reveman <reveman@chromium.org> Date: Fri Nov 03 05:16:44 2017 Login: Fix horizontal flip for supervised user image grid. Use flipped image instead of relying on css transform for image preview. This allows both the grid image and the image preview to be displayed correctly. TBR=reveman@chromium.org (cherry picked from commit 41e6d26e78c2426341f2210f8979be3de1aa8244) Bug: 779519 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icd0fb45f1dc433d490f24d5342c250197e96c11b Reviewed-on: https://chromium-review.googlesource.com/743693 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#512564} Reviewed-on: https://chromium-review.googlesource.com/752584 Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#363} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/105ccce69ec9f1c599bb02cb1f469e73d19ca3fd/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.css [modify] https://crrev.com/105ccce69ec9f1c599bb02cb1f469e73d19ca3fd/chrome/browser/resources/chromeos/user_images_grid.js
,
Nov 10 2017
Verified on M64 dev build (10115.0.0, 64.0.3264.0). |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 Deleted