Chrome logo intermittently fails to load on chrome://settings/help
Reported by
nutan.ga...@etouch.net,
Oct 30 2017
|
||||||||||||||
Issue descriptionChrome Version: 63.0.3239.26 4dc4a1fadfb64aefa5850be806dac60336406dd9-refs/branch-heads/3239@{#286} 32/64 OS: Windows 10 Touch device What steps will reproduce the problem? 1. Launch chrome, navigate to chrome://settings/help 2. Reload the page continuously and observe the chrome browser icon Actual: Broken image is seen on chrome browser icon after reloading the page Expected: Broken image should not be seen This is a Win 10 touch device specific regression issue, broken in 'M-63'. Good Build: 63.0.3236.0 Bad Build: 63.0.3237.7 You are probably looking for a change made after 507308 (known good), but no later than 507309 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/3d78f85688013c07642ee7b8d437ba0da2f96d69..6abc19e88235609c7b8fc9df464beed2b667a773 Suspect: https://chromium.googlesource.com/chromium/src/+/6abc19e88235609c7b8fc9df464beed2b667a773 Note: Issue is not reproducible on Mac and Linux
,
Oct 30 2017
,
Oct 30 2017
,
Oct 30 2017
The markup used in the page means that when the page fails to load we display a broken image icon as well as the alt text. The underlying bug is that the image occasionally fails to load. You should reassign to the loading team maybe? Lowering priority as the erratic image loads seem to be preexisting behaviour.
,
Oct 30 2017
,
Oct 30 2017
With respect to comment 4: Re-bisected for the above issue and getting same suspect i.e. Suspect: https://chromium.googlesource.com/chromium/src/+/6abc19e88235609c7b8fc9df464beed2b667a773 @robhogan: Please help to re-assign this issue if your change is not the cause for it.
,
Nov 1 2017
Randomly assigning to an owner of the UI>Settings component. The underlying issue is a loading one, but it might require some insight from the page author to understand how the page is loading the image in order to troubleshoot the erratic load failures.
,
Nov 1 2017
I don't really have much to add. The code that displays this icon is at [1]. Also pasting here:
<img id="product-logo" on-tap="onProductLogoTap_"
srcset="chrome://theme/current-channel-logo@1x 1x,
chrome://theme/current-channel-logo@2x 2x"
alt="$i18n{aboutProductLogoAlt}">
It seems plausible that something related to the bisect CL changed the behavior of srcset.
[1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/about_page/about_page.html?q=about_page.html&sq=package:chromium&dr&l=91-94
,
Nov 2 2017
If you look at 'Expected Video.mp4', the image load was failing erratically before my CL already. That's the root of the issue - this bug is a WontFix in the sense that displaying the broken image icon as well as the alt text when the image fails to load is new, intentional behaviour. We need someone with loading expertise to understand why that image load is failing intermittently, and my thinking was that the first step in that investigation would be to understand how the page is initiating its image loads. Seems the problem must be specific to the way chrome:// urls are resolved. cc'ing some loading folks from Source/core/loader/OWNERS
,
Nov 2 2017
,
Nov 2 2017
,
Mar 21 2018
[nutan.gaikwad]: Can you still reproduce this? I can't on Chrome 65 (Tried both Windows 10 and OSX). If you can, could you attach a net-export log of this issue? That would hopefully at least let us narrow it down to an issue above or below the network stack. Instructions: https://www.chromium.org/for-testers/providing-network-details
,
Apr 17 2018
ping nutan.gaikwad: can you please respond to comment #12? Thanks!
,
Apr 18 2018
With respect to comment 12: Above issue seems to be fixed and it is more reprocible on M-66 Stable build #66.0.3359.117,M-67 Dev build #67.0.3393.4 and M-68 canary biuld #68.0.3398.0 Thank you.
,
Apr 18 2018
Coreection in comment 14: Above issue seems to be fixed and it is not reprocible on M-66 Stable build #66.0.3359.117,M-67 Dev build #67.0.3393.4 and M-68 canary biuld #68.0.3398.0 Kindly review attached screencast for the same. Thank you.
,
Apr 18 2018
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Oct 30 2017