New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 779511 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Chrome logo intermittently fails to load on chrome://settings/help

Reported by nutan.ga...@etouch.net, Oct 30 2017

Issue description

Chrome Version: 63.0.3239.26 4dc4a1fadfb64aefa5850be806dac60336406dd9-refs/branch-heads/3239@{#286} 32/64
OS: Windows 10 Touch device

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://settings/help  
2. Reload the page continuously and observe the chrome browser icon

Actual: Broken image is seen on chrome browser icon after reloading the page
Expected: Broken image should not be seen

This is a Win 10 touch device specific regression issue, broken in 'M-63'.

Good Build: 63.0.3236.0
Bad Build: 63.0.3237.7

You are probably looking for a change made after 507308 (known good), but no later than 507309 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  
https://chromium.googlesource.com/chromium/src/+log/3d78f85688013c07642ee7b8d437ba0da2f96d69..6abc19e88235609c7b8fc9df464beed2b667a773

Suspect: https://chromium.googlesource.com/chromium/src/+/6abc19e88235609c7b8fc9df464beed2b667a773

Note: Issue is not reproducible on Mac and Linux
 
Actual Video.mp4
466 KB View Download
Expected Video.mp4
400 KB View Download
Labels: ReleaseBlock-Stable
Tagging with blocker label, please undo if not the case.
Labels: -Pri-2 Pri-1
Labels: -M-64 M-63

Comment 4 by robho...@gmail.com, Oct 30 2017

Components: Blink>Image Blink>Loader
Labels: -Pri-1 -ReleaseBlock-Stable Hotlist-Loading Pri-2
Status: Available (was: Assigned)
The markup used in the page means that when the page fails to load we display a broken image icon as well as the alt text. The underlying bug is that the image occasionally fails to load. You should reassign to the loading team maybe?

Lowering priority as the erratic image loads seem to be preexisting behaviour.

Comment 5 by robho...@gmail.com, Oct 30 2017

Owner: nyerramilli@chromium.org
Components: Internals>Input>Touch>Screen
Labels: hasbisect-per-revision Proj-Windows10
Owner: robho...@gmail.com
Status: Assigned (was: Available)
With respect to comment 4:

Re-bisected for the above issue and getting same suspect i.e. 

Suspect: https://chromium.googlesource.com/chromium/src/+/6abc19e88235609c7b8fc9df464beed2b667a773

@robhogan: Please help to re-assign this issue if your change is not the cause for it. 

Comment 7 by robho...@gmail.com, Nov 1 2017

Owner: dpa...@chromium.org
Randomly assigning to an owner of the UI>Settings component. The underlying issue is a loading one, but it might require some insight from the page author to understand how the page is loading the image in order to troubleshoot the erratic load failures.
Owner: nyerramilli@chromium.org
I don't really have much to add. The code that displays this icon is at [1]. Also pasting here:

<img id="product-logo" on-tap="onProductLogoTap_"
  srcset="chrome://theme/current-channel-logo@1x 1x,
          chrome://theme/current-channel-logo@2x 2x"
  alt="$i18n{aboutProductLogoAlt}">

It seems plausible that something related to the bisect CL changed the behavior of srcset.


[1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/about_page/about_page.html?q=about_page.html&sq=package:chromium&dr&l=91-94

Comment 9 by robho...@gmail.com, Nov 2 2017

Cc: mkwst@chromium.org japhet@chromium.org
Components: -Internals>Input>Touch>Screen -UI>Settings Internals>Network
If you look at 'Expected Video.mp4', the image load was failing erratically before my CL already. That's the root of the issue - this bug is a WontFix in the sense that displaying the broken image icon as well as the alt text when the image fails to load is new, intentional behaviour.

We need someone with loading expertise to understand why that image load is failing intermittently, and my thinking was that the first step in that investigation would be to understand how the page is initiating its image loads. Seems the problem must be specific to the way chrome:// urls are resolved.

cc'ing some loading folks from Source/core/loader/OWNERS
Labels: -Type-Bug-Regression -hasbisect-per-revision -M-63 Type-Bug
Summary: Chrome logo intermittently fails to load on chrome://settings/help (was: Regression: Broken image is seen on chrome browser icon after reloading the page)
Owner: ----
Status: Available (was: Assigned)
Labels: Needs-Feedback
[nutan.gaikwad]:  Can you still reproduce this?  I can't on Chrome 65 (Tried both Windows 10 and OSX).  If you can, could you attach a net-export log of this issue?  That would hopefully at least let us narrow it down to an issue above or below the network stack.  Instructions:  https://www.chromium.org/for-testers/providing-network-details
ping nutan.gaikwad: can you please respond to comment #12? Thanks!

Comment 14 by db...@etouch.net, Apr 18 2018

Labels: -Needs-Feedback
With respect to comment 12:

Above issue seems to be fixed and it is more reprocible on M-66 Stable build #66.0.3359.117,M-67 Dev build #67.0.3393.4 and M-68 canary biuld #68.0.3398.0 

Thank you.

Comment 15 by db...@etouch.net, Apr 18 2018

Coreection in comment 14:

Above issue seems to be fixed and it is not reprocible on M-66 Stable build #66.0.3359.117,M-67 Dev build #67.0.3393.4 and M-68 canary biuld #68.0.3398.0 

Kindly review attached screencast for the same.

Thank you.
Fix_Actual.mp4
392 KB View Download
Status: Verified (was: Available)

Sign in to add a comment