Regression : Unnecessarily tool tip is seen even when 'Clear browsing data' is disabled from Main menu in chrome://history.
Reported by
rp...@etouch.net,
Oct 30 2017
|
|||||||||
Issue descriptionVersion: 63.0.3239.26 (32/64-bit)4dc4a1fadfb64aefa5850be806dac60336406dd9-refs/branch-heads/3239@{#286} OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1) What steps will reproduce the problem? 1. Launch chrome, navigate to 'Guest' mode 2. Now navigate to chrome://history page and resize window from RHS to LHS such as 'Main menu' button is visible 3. Now observe 'You can clear your browsing data from this menu' tool tip Actual: Unnecessarily 'You can clear your browsing data from this menu' tool tip is seen even when 'Clear browsing data' is disabled in 'Main menu' Expected: Unnecessarily 'You can clear your browsing data from this menu' tool tip should not be seen when 'Clear browsing data' is disabled in 'Main menu' This is regression issue, broken in ‘M 60’ and will soon update other info : Good build:60.0.3074.0 (Revision: 465086) Bad build: 60.0.3075.0 (Revision: 465641) You are probably looking for a change made after 465153 (known good), but no lat er than 465154 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/3c24f4f7064cb6fcf8827bd5bd29ec12664dbd3d..dcf200334b52ac07d81baaec5257e4a964fa3137 From the CL above, assigning the issue to the concern owner @tsergeant- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Suspect : https://chromium.googlesource.com/chromium/src/+/dcf200334b52ac07d81baaec5257e4a964fa3137 Thanks!
,
Nov 2 2017
,
Nov 9 2017
I'm interested in making a patch for this. May I start this issue?
,
Nov 9 2017
Go for it!
,
Nov 13 2017
Submitted patch https://chromium-review.googlesource.com/c/chromium/src/+/762811 for review. Could you tell me if this is the right direction? Thanks in advance!
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c342372bf5560dbceccb07339f5abf8fc6ba1bbc commit c342372bf5560dbceccb07339f5abf8fc6ba1bbc Author: Kyoungdeok Kwon <kkd927@gmail.com> Date: Wed Nov 15 08:24:19 2017 [MD History] Unnecessarily tool tip is seen even when 'Clear browsing data' is disabled Unnecessarily 'You can clear your browsing data from this menu' tool tip is seen even when 'Clear browsing data' is disabled from Main menu in chrome://history. Bug: 779499 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6242e58de7e85bec2f7adbf52821b4368e374358 Reviewed-on: https://chromium-review.googlesource.com/762811 Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#516635} [modify] https://crrev.com/c342372bf5560dbceccb07339f5abf8fc6ba1bbc/chrome/browser/resources/md_history/history_toolbar.html [modify] https://crrev.com/c342372bf5560dbceccb07339f5abf8fc6ba1bbc/chrome/browser/resources/md_history/history_toolbar.js
,
Nov 16 2017
Thanks for the patch!
,
Nov 16 2017
Note : Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1) with latest canary chrome://version : 64.0.3270.0 and the issue is not reproduced.Kindly refer the attached screen cast for reference.
,
Nov 16 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by tsergeant@chromium.org
, Oct 31 2017