Spec: https://drafts.css-houdini.org/css-typed-om-1/#normalize-tokens
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47b0b6ca47de80704b6ac0076bdf98a11b29b006 commit 47b0b6ca47de80704b6ac0076bdf98a11b29b006 Author: Darren Shen <shend@chromium.org> Date: Wed Dec 06 02:46:38 2017 [css-typed-om] Normalize custom property declarations. When parsing custom properties or retrieving them from CSSOM, we need to return a CSSUnparsedValue. Spec: https://drafts.css-houdini.org/css-typed-om-1/#normalize-tokens Bug: 788570 , 779477 Change-Id: Ia2fa289dc076ffd6dbacf03822907663209c6284 Reviewed-on: https://chromium-review.googlesource.com/804920 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#521969} [modify] https://crrev.com/47b0b6ca47de80704b6ac0076bdf98a11b29b006/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/style-background-image.https.html [modify] https://crrev.com/47b0b6ca47de80704b6ac0076bdf98a11b29b006/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/style-before-pseudo.https.html [modify] https://crrev.com/47b0b6ca47de80704b6ac0076bdf98a11b29b006/third_party/WebKit/LayoutTests/typedcssom/stylevalue-normalization/normalize-tokens.html [delete] https://crrev.com/fe2b322b600dd7332610f601800722ae4fff00e6/third_party/WebKit/LayoutTests/typedcssom/stylevalue-objects/parse-parseAll-expected.txt [modify] https://crrev.com/47b0b6ca47de80704b6ac0076bdf98a11b29b006/third_party/WebKit/LayoutTests/typedcssom/stylevalue-objects/parse-parseAll.html [modify] https://crrev.com/47b0b6ca47de80704b6ac0076bdf98a11b29b006/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/computed-expected.txt [delete] https://crrev.com/fe2b322b600dd7332610f601800722ae4fff00e6/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/get-expected.txt [delete] https://crrev.com/fe2b322b600dd7332610f601800722ae4fff00e6/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/getAll-expected.txt [modify] https://crrev.com/47b0b6ca47de80704b6ac0076bdf98a11b29b006/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.cpp [modify] https://crrev.com/47b0b6ca47de80704b6ac0076bdf98a11b29b006/third_party/WebKit/Source/core/css/cssom/CSSUnparsedValue.cpp [modify] https://crrev.com/47b0b6ca47de80704b6ac0076bdf98a11b29b006/third_party/WebKit/Source/core/css/cssom/CSSUnparsedValue.h [modify] https://crrev.com/47b0b6ca47de80704b6ac0076bdf98a11b29b006/third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp
Iterating over StylePropertyMaps still return CSSStyleValues instead of CSSUnparsedValues.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae23b054443fed371e988603958359984f64162b commit ae23b054443fed371e988603958359984f64162b Author: Darren Shen <shend@chromium.org> Date: Tue Dec 12 08:41:15 2017 [css-typed-om] Return CSSUnparsedValue when iterating over CSS variables Currently, when we encounted a custom property as we iterate over a StylePropertyMap, we get back a CSSUnsupportedValue, but we should be returning a CSSUnparsedValue. Spec: https://drafts.css-houdini.org/css-typed-om-1/#unparsedvalue-objects Bug: 779477 Change-Id: Iad5cf293e7e5721635f203e0a54d41759da508fc Reviewed-on: https://chromium-review.googlesource.com/821890 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#523374} [modify] https://crrev.com/ae23b054443fed371e988603958359984f64162b/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_iteration.html [modify] https://crrev.com/ae23b054443fed371e988603958359984f64162b/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/iterable-expected.txt [modify] https://crrev.com/ae23b054443fed371e988603958359984f64162b/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp
It's fixed for the inline style property map. Once we refactor style property map iteration, this should automatically work for computed and declared style property maps.
Comment 1 by rjwright@chromium.org
, Oct 31 2017