The new `probe` framework is ready now, so it's time to deprecate `gooftool probe`.
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/23f8fe4784d4ee1de62a6edf3ec986877f336f0e commit 23f8fe4784d4ee1de62a6edf3ec986877f336f0e Author: Yong Hong <yhong@chromium.org> Date: Tue Dec 12 19:09:12 2017 vpd: Implements a helper class to call vpd cmdline tool in `sys_utils`. This CL moves the calling logic from `py/device/vpd.py` to `py/utils/sys_utils.py` so that modules such as `gooftool` can call vpd cmdline tool easily. BUG= chromium:779466 CQ-DEPEND=CL:727503 TEST=make test Change-Id: I549496a413fae8e9df05544176d93b235771f916 Reviewed-on: https://chromium-review.googlesource.com/760296 Commit-Ready: Yong Hong <yhong@google.com> Tested-by: Yong Hong <yhong@google.com> Reviewed-by: Yong Hong <yhong@google.com> [modify] https://crrev.com/23f8fe4784d4ee1de62a6edf3ec986877f336f0e/py/device/vpd_unittest.py [modify] https://crrev.com/23f8fe4784d4ee1de62a6edf3ec986877f336f0e/py/device/vpd.py [modify] https://crrev.com/23f8fe4784d4ee1de62a6edf3ec986877f336f0e/py/utils/sys_utils_unittest.py [modify] https://crrev.com/23f8fe4784d4ee1de62a6edf3ec986877f336f0e/py/utils/sys_utils.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/ae030c4e2ca1a66ab1607b56664cf0e5e2ae86cd commit ae030c4e2ca1a66ab1607b56664cf0e5e2ae86cd Author: Yong Hong <yhong@chromium.org> Date: Wed Dec 20 13:49:36 2017 sys_utils: Fixes a typo of the argument for the vpd cmdline tool. TEST=make test; manually test BUG= chromium:779466 Change-Id: I2ce8c8928d4e52ff07be3cef2fb4b5d622a79222 Reviewed-on: https://chromium-review.googlesource.com/836293 Commit-Ready: Yong Hong <yhong@google.com> Tested-by: Yong Hong <yhong@google.com> Reviewed-by: Youcheng Syu <youcheng@chromium.org> [modify] https://crrev.com/ae030c4e2ca1a66ab1607b56664cf0e5e2ae86cd/py/utils/sys_utils_unittest.py [modify] https://crrev.com/ae030c4e2ca1a66ab1607b56664cf0e5e2ae86cd/py/utils/sys_utils.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/b59a56bf257f9a7e62eb7322d099abaa44d55cee commit b59a56bf257f9a7e62eb7322d099abaa44d55cee Author: Yong Hong <yhong@chromium.org> Date: Wed Dec 20 13:50:25 2017 sys_utils: Fixes a typo of the argument for the vpd cmdline tool. TEST=make test; manually test BUG= chromium:779466 Change-Id: I2ce8c8928d4e52ff07be3cef2fb4b5d622a79222 Reviewed-on: https://chromium-review.googlesource.com/836327 Reviewed-by: Youcheng Syu <youcheng@chromium.org> Commit-Queue: Youcheng Syu <youcheng@chromium.org> Tested-by: Youcheng Syu <youcheng@chromium.org> Trybot-Ready: Youcheng Syu <youcheng@chromium.org> [modify] https://crrev.com/b59a56bf257f9a7e62eb7322d099abaa44d55cee/py/utils/sys_utils_unittest.py [modify] https://crrev.com/b59a56bf257f9a7e62eb7322d099abaa44d55cee/py/utils/sys_utils.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/863d3265e18f7d4c324af5c77b3b19a9b8de0423 commit 863d3265e18f7d4c324af5c77b3b19a9b8de0423 Author: Yong Hong <yhong@chromium.org> Date: Thu Dec 21 09:04:36 2017 gooftool: Deprecates the `probe` module. This CL deprecates `py/gooftool/probe.py` and replaces all the use cases by the generic probing method of the new `py/probe` framework. After we finished the integration of probe framework/HWID and the AVL, we will replace the generic probing method with the passive probing method. BUG= chromium:779466 TEST=make test; manually test on DUT Change-Id: I4fcdd37841834e1e9c49c7f00c34f9ef5080aa62 [modify] https://crrev.com/863d3265e18f7d4c324af5c77b3b19a9b8de0423/py/probe/functions/generic_usb_hosts.py [modify] https://crrev.com/863d3265e18f7d4c324af5c77b3b19a9b8de0423/py/probe/functions/generic_tpm.py [modify] https://crrev.com/863d3265e18f7d4c324af5c77b3b19a9b8de0423/py/probe/functions/generic_audio_codec.py [modify] https://crrev.com/863d3265e18f7d4c324af5c77b3b19a9b8de0423/py/probe/volatile_statement.json [modify] https://crrev.com/863d3265e18f7d4c324af5c77b3b19a9b8de0423/py/probe/functions/vpd.py [add] https://crrev.com/863d3265e18f7d4c324af5c77b3b19a9b8de0423/py/gooftool/testdata/CHROMEBOOK [delete] https://crrev.com/b14bba2c25ffed3b1373dd7c2ff2f5f5fa7ad26c/py/gooftool/probe_unittest.py [modify] https://crrev.com/863d3265e18f7d4c324af5c77b3b19a9b8de0423/py/hwid/v3/hwid_cmdline.py [modify] https://crrev.com/863d3265e18f7d4c324af5c77b3b19a9b8de0423/py/probe/functions/generic_bluetooth.py [modify] https://crrev.com/863d3265e18f7d4c324af5c77b3b19a9b8de0423/py/hwid/README.md [modify] https://crrev.com/863d3265e18f7d4c324af5c77b3b19a9b8de0423/py/probe/functions/generic_cpu.py [modify] https://crrev.com/863d3265e18f7d4c324af5c77b3b19a9b8de0423/py/hwid/v2/hwid_unittest.py [modify] https://crrev.com/863d3265e18f7d4c324af5c77b3b19a9b8de0423/py/hwid/v3/database.py [delete] https://crrev.com/b14bba2c25ffed3b1373dd7c2ff2f5f5fa7ad26c/py/gooftool/testdata/BENDER [modify] https://crrev.com/863d3265e18f7d4c324af5c77b3b19a9b8de0423/py/probe/functions/generic_storage.py [modify] https://crrev.com/863d3265e18f7d4c324af5c77b3b19a9b8de0423/py/probe/functions/generic_video.py [delete] https://crrev.com/b14bba2c25ffed3b1373dd7c2ff2f5f5fa7ad26c/py/gooftool/testdata/test_data.yaml [delete] https://crrev.com/b14bba2c25ffed3b1373dd7c2ff2f5f5fa7ad26c/py/gooftool/testdata/component_db [modify] https://crrev.com/863d3265e18f7d4c324af5c77b3b19a9b8de0423/py/hwid/v3/hwid_utils.py [modify] https://crrev.com/863d3265e18f7d4c324af5c77b3b19a9b8de0423/py/probe/functions/vpd_unittest.py [delete] https://crrev.com/b14bba2c25ffed3b1373dd7c2ff2f5f5fa7ad26c/py/gooftool/probe.py [modify] https://crrev.com/863d3265e18f7d4c324af5c77b3b19a9b8de0423/py/probe/functions/generic_battery.py [modify] https://crrev.com/863d3265e18f7d4c324af5c77b3b19a9b8de0423/py/gooftool/gooftool_unittest.py [modify] https://crrev.com/863d3265e18f7d4c324af5c77b3b19a9b8de0423/py/hwid/v2/hwid_tool.py [modify] https://crrev.com/863d3265e18f7d4c324af5c77b3b19a9b8de0423/py/probe/functions/generic_dram.py [modify] https://crrev.com/863d3265e18f7d4c324af5c77b3b19a9b8de0423/py/gooftool/core.py [modify] https://crrev.com/863d3265e18f7d4c324af5c77b3b19a9b8de0423/py/gooftool/commands.py [modify] https://crrev.com/863d3265e18f7d4c324af5c77b3b19a9b8de0423/py/test/pytests/hwid_v3.py [modify] https://crrev.com/863d3265e18f7d4c324af5c77b3b19a9b8de0423/py/hwid/v3/builder.py
Comment 1 by yhong@chromium.org
, Oct 30 2017