New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 779456 link

Starred by 1 user
Status: Fixed
Owner:
lijeffrey@chromium.org
Closed: Nov 2017
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Move logic for computing nearest containing build number to shared location

Project Member Reported by lijeffrey@chromium.org, Oct 30 2017 
Flake analyzer has the ability to determine the nearest containing build number given a commit position, however this code lives inside manual regression range analysis. This should be moved to a shared location so other modules can benefit from it as well
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/1569ec4e00a17982d35784962a7a12283d56a378

commit 1569ec4e00a17982d35784962a7a12283d56a378
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Mon Oct 30 05:00:21 2017

[Findit] Flake Analyzer - Moving build info functions to shared location

In preparation for creating a pipeline to map a commit position to an
isolated sha, some functionality should first be moved to a shared
location as part of refactoring efforts for Flake Analyzer.

This CL should not introduce any functional changes, but rather serves
to move code around only.

Bug:  779456 
Change-Id: I651befeb0f1f0610d83431939025f741fcaccb36
Reviewed-on: https://chromium-review.googlesource.com/737412
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/1569ec4e00a17982d35784962a7a12283d56a378/appengine/findit/waterfall/build_util.py
[modify] https://crrev.com/1569ec4e00a17982d35784962a7a12283d56a378/appengine/findit/waterfall/flake/regression_range_analysis_pipeline.py
[modify] https://crrev.com/1569ec4e00a17982d35784962a7a12283d56a378/appengine/findit/waterfall/test/build_util_test.py
[modify] https://crrev.com/1569ec4e00a17982d35784962a7a12283d56a378/appengine/findit/waterfall/flake/test/regression_range_analysis_pipeline_test.py

Comment 2 by lijeffrey@chromium.org, Nov 15 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment