Detail is https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOGYzNDYzOGMzOWJiOWE2NDg1MzQ2MmIxZjRhYmI3M2M1ZWUzYjIxZAw The mentioned CL changes the behavior only when LayoutNG runtime flag is enabled, so likely incorrect.
Many thanks for the bug report! It seems Findit is still misinterpreting errors as nonexistent tests (in this case, it looks like something crashed) causing the immediate CL that's flaky after that point to be "the culprit"
Since this causes false positive, let's give it a priority to fix it.
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/2fc37a07836ca9c18e631a87c3ff037d3f5b5606 commit 2fc37a07836ca9c18e631a87c3ff037d3f5b5606 Author: Jeffrey Li <lijeffrey@chromium.org> Date: Wed Nov 15 22:47:21 2017 [Findit] Flake Analyzer - Adding improved detection for nonexistent tests Implementing additional criteria for determining a nonexistent test by check all_tests in the response for the test name when processing the test results in case there no results. If the test exists in all_tests yet there are no results, treat the task as having had an error. Bug: 779435 Change-Id: Ic66343caf534b34d1a2cc60db1593179d4cd6051 Reviewed-on: https://chromium-review.googlesource.com/751776 Reviewed-by: Brandon Wylie <wylieb@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> Commit-Queue: Jeffrey Li <lijeffrey@chromium.org> [modify] https://crrev.com/2fc37a07836ca9c18e631a87c3ff037d3f5b5606/appengine/findit/services/test/gtest_test.py [modify] https://crrev.com/2fc37a07836ca9c18e631a87c3ff037d3f5b5606/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py [modify] https://crrev.com/2fc37a07836ca9c18e631a87c3ff037d3f5b5606/appengine/findit/waterfall/flake/test/analyze_flake_for_build_number_pipeline_test.py [modify] https://crrev.com/2fc37a07836ca9c18e631a87c3ff037d3f5b5606/appengine/findit/waterfall/test/process_swarming_task_result_pipeline_test.py [modify] https://crrev.com/2fc37a07836ca9c18e631a87c3ff037d3f5b5606/appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py [modify] https://crrev.com/2fc37a07836ca9c18e631a87c3ff037d3f5b5606/appengine/findit/waterfall/test/process_flake_swarming_task_result_pipeline_test.py [modify] https://crrev.com/2fc37a07836ca9c18e631a87c3ff037d3f5b5606/appengine/findit/waterfall/test/process_base_swarming_task_result_pipeline_test.py [modify] https://crrev.com/2fc37a07836ca9c18e631a87c3ff037d3f5b5606/appengine/findit/waterfall/flake/analyze_flake_for_build_number_pipeline.py [modify] https://crrev.com/2fc37a07836ca9c18e631a87c3ff037d3f5b5606/appengine/findit/waterfall/test/process_swarming_tasks_result_pipeline_test.py [modify] https://crrev.com/2fc37a07836ca9c18e631a87c3ff037d3f5b5606/appengine/findit/services/gtest.py [modify] https://crrev.com/2fc37a07836ca9c18e631a87c3ff037d3f5b5606/appengine/findit/waterfall/swarming_util.py [modify] https://crrev.com/2fc37a07836ca9c18e631a87c3ff037d3f5b5606/appengine/findit/waterfall/flake/trigger_flake_swarming_task_service_pipeline.py
Comment 1 by lijeffrey@chromium.org
, Oct 30 2017Status: Assigned (was: Available)