New issue
Advanced search Search tips

Issue 779422 link

Starred by 1 user
Status: Fixed
Owner:
shend@chromium.org
Closed: Oct 2017
Cc:
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 545318



Sign in to add a comment

[css-typed-om] CSSStyleValue.parse should return first element of list-valued property

Project Member Reported by shend@chromium.org, Oct 29 2017 
When giving a list-valued property, CSSStyleValue.parse should return the first value only.

Spec: https://drafts.css-houdini.org/css-typed-om-1/#dom-cssstylevalue-parse

Test Failure:
FAIL Calling CSSStyleValue.parse with a list-value property returns first list value Cannot read property 'constructor' of null
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f409410057299c0591f050ef169a4de4c9cada1

commit 3f409410057299c0591f050ef169a4de4c9cada1
Author: Darren Shen <shend@chromium.org>
Date: Mon Oct 30 04:21:39 2017

[css-typed-om] Make CSSStyleValue.parse work with list-valued properties

Currently, when given a list value, CSSStyleValue.parse returns null,
but the spec says to take the first entry:

https://drafts.css-houdini.org/css-typed-om-1/#dom-cssstylevalue-parse

Bug:  779422 
Change-Id: I9f80d1876b9390f1d2684c271d3db3ef4192ddd3
Reviewed-on: https://chromium-review.googlesource.com/743101
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512440}
[modify] https://crrev.com/3f409410057299c0591f050ef169a4de4c9cada1/third_party/WebKit/LayoutTests/typedcssom/stylevalue-objects/parse-parseAll-expected.txt
[modify] https://crrev.com/3f409410057299c0591f050ef169a4de4c9cada1/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.cpp

Comment 2 by shend@chromium.org, Oct 30 2017

Status: Fixed (was: Started)

Comment 3 by nainar@chromium.org, Nov 29 2017

Labels: -Type-Bug -Hotlist-Interop Type-Feature
►

Sign in to add a comment