New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 779419 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::ImageData::ImageDataInCanvasColorSettings

Project Member Reported by ClusterFuzz, Oct 29 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4999605795422208

Fuzzer: inferno_twister
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000010
Crash State:
  blink::ImageData::ImageDataInCanvasColorSettings
  blink::BaseRenderingContext2D::putImageData
  blink::BaseRenderingContext2D::putImageData
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=512337:512373

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4999605795422208

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Cc: kkaluri@chromium.org
Components: Blink>Image
Labels: M-64 Test-Predator-Wrong
Owner: zakerinasab@chromium.org
Status: Assigned (was: Untriaged)
Predator could not provide any possible suspects.
Using the CL search for the file, “ImageData.cpp” assigning to concern owner.

Suspecting Commit#  https://chromium.googlesource.com/chromium/src/+/03414af91b3af6aa6176b256ad77ec03aff592cd

zakerinasab@ -- Could you please look into this issue, kindly reassign if it has nothing to do with your changes.


Thank You.
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a05882d97b412855b467541a95f3a5cc0b33b57

commit 9a05882d97b412855b467541a95f3a5cc0b33b57
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Mon Oct 30 19:04:41 2017

Fix the crash in ImageDataInCanvasColorSettings

Passing an ImageData that is created from U16/F32 data but does not
have a color settings to ImageDataInCanvasColorSettings results
in a crash. This change temporarily fixes this until the proper color
space (extended-srgb) is provided.

Bug:  779419 
Change-Id: I491fa86f53b73473cba514512e64de69db49fc91
Reviewed-on: https://chromium-review.googlesource.com/743804
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512565}
[modify] https://crrev.com/9a05882d97b412855b467541a95f3a5cc0b33b57/third_party/WebKit/LayoutTests/virtual/color_space/fast/canvas/color-space/imageData-colorSpace.html
[add] https://crrev.com/9a05882d97b412855b467541a95f3a5cc0b33b57/third_party/WebKit/LayoutTests/virtual/color_space/fast/canvas/color-space/imagedata-no-color-settings-crash.html
[modify] https://crrev.com/9a05882d97b412855b467541a95f3a5cc0b33b57/third_party/WebKit/Source/core/html/ImageData.cpp

Status: Fixed (was: Started)
Project Member

Comment 5 by ClusterFuzz, Oct 31 2017

Components: Blink>Canvas Blink>HTML
Labels: Test-Predator-AutoComponents
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 6 by ClusterFuzz, Oct 31 2017

ClusterFuzz has detected this issue as fixed in range 512560:512590.

Detailed report: https://clusterfuzz.com/testcase?key=4999605795422208

Fuzzer: inferno_twister
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000010
Crash State:
  blink::ImageData::ImageDataInCanvasColorSettings
  blink::BaseRenderingContext2D::putImageData
  blink::BaseRenderingContext2D::putImageData
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=512337:512373
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=512560:512590

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4999605795422208

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Oct 31 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 4999605795422208 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: Test-Predator-Auto-CC
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components
Labels: -Test-Predator-Auto-CC

Sign in to add a comment