Display Invalid Configurations so they can be edited |
||
Issue descriptionWe're suppressing display of printers with invalid configuration because it was leading to crashes. However, users should be allowed to attempt to fix said configurations with whatever they've filled out. We should also attempt to validate uris in the setup field.
,
Dec 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5cb0339fb2376e0096f41459e46ce41b51d66ac4 commit 5cb0339fb2376e0096f41459e46ce41b51d66ac4 Author: Sean Kau <skau@chromium.org> Date: Fri Dec 08 23:31:27 2017 Ensure that GetPrinterInfo always returns a valid value. Allowing GetPrinterInfo to return null was causing a crash if uris were invalid. However, excluding printers which have invalid uris make them impossible to correct. Bug: 779386 Change-Id: Ie5ebd8c3834a5d988f3f6d8a3cec7c2ea05dd9d6 Reviewed-on: https://chromium-review.googlesource.com/742308 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#522919} [modify] https://crrev.com/5cb0339fb2376e0096f41459e46ce41b51d66ac4/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
,
Jan 18 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by skau@chromium.org
, Oct 29 2017