New issue
Advanced search Search tips

Issue 779385 link

Starred by 2 users

Issue metadata

Status: Unconfirmed
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Document Bug

Reported by mkhah...@gmail.com, Oct 29 2017

Issue description

In the following developer page the description for the "matches" param says 'http://*.chromium.org/*' is valid while 'http://*.appspot.com/*' is not. I'm wondering what is the difference between these two patterns?!

https://developer.chrome.com/apps/manifest/externally_connectable#reference

 

Comment 1 by woxxom@gmail.com, Oct 29 2017

appspot.com is not a single site, but a suffix like .github.io shared by independent sites.
See Public Suffix List: https://publicsuffix.org/list/public_suffix_list.dat

Comment 2 by mkhah...@gmail.com, Oct 29 2017

Got it! Thanks for the clarification. Although it was better to use a common example like '*.edu.ac'.

Comment 3 by woxxom@gmail.com, Oct 29 2017

I agree the documentation is unclear and even misleading.
Also, if Public Suffix List is used internally, it must be mentioned explicitly.

Comment 4 by woxxom@gmail.com, Oct 29 2017

Yep, externally_connectable uses Public Suffix List internally [1] so the documentation should mention it explicitly.
[1]: https://cs.chromium.org/chromium/src/net/base/registry_controlled_domains/effective_tld_names.dat

Comment 5 by mkhah...@gmail.com, Oct 29 2017

Actually I expected to be able to use 'https://*.localhost/*' for my tests but I can't. Is localhost a suffix too?

Comment 6 by woxxom@gmail.com, Oct 29 2017

You can add a dummy domain to etc/hosts that resolves to 127.0.0.1
In Windows it's %windir%\System32\drivers\etc\hosts

Comment 7 by mkhah...@gmail.com, Oct 29 2017

Yes I have defined multiple domains (e.g. srv1.localhost, srv2.localhost, etc) in hosts file which point to different local IPs (e.g. 192.168.1.10, 192.168.1.11, etc) but it seems I have to list the domains in the manifest file and can not use *.localhost.

Comment 8 by woxxom@gmail.com, Oct 29 2017

Not sure localhost can be used as a suffix.
I meant something more realistic like srv1.com, for example.

Comment 9 by mkhah...@gmail.com, Oct 29 2017

Then *.com would be invalid unless I use a real domain like *.my-domain.com.
I'll try that. Thanks for your thoughts any way.
Labels: Needs-Milestone Documentation
Adding appropriate label for further triage.

Thanks!

Comment 11 by ajha@chromium.org, Apr 18 2018

Components: Platform>Extensions>Documentation
Labels: TE-NeedsTriageHelp
Adding TE-NeedsTriageHelp for moving this Unconfirmed issue out of TE's triaging bucket.

Sign in to add a comment