New issue
Advanced search Search tips

Issue 779380 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Undefined-shift in AllPassFilter

Project Member Reported by ClusterFuzz, Oct 29 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5971868573237248

Fuzzer: libFuzzer_neteq_signal_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  AllPassFilter
  SplitFilter
  WebRtcVad_CalculateFeatures
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=510532:510572

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5971868573237248

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Cc: kkaluri@chromium.org
Components: Blink>WebRTC
Labels: M-64 Test-Predator-Wrong
Owner: aleloi@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.
Using the Code search for the file, “vad_filterbank.c” assigning to concern owner.

Suspecting Commit# https://webrtc.git.corp.google.com/src.git/+/b9f536167c951558cce8ab18a5012e0822d18855

aleloi@ -- Could you please look into this issue, kindly reassign if it has nothing to do with your changes.


Thank You.
Cc: hlundin@chromium.org
This is triggered by new NetEq signal fuzzer, which I activated about a week ago. So, the error itself could be ancient, or introduced recently.

Alex, do you mind taking a look anyway?
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/aeb5d88dee9998a26fbe3f76790007a8f2fc98f7

commit aeb5d88dee9998a26fbe3f76790007a8f2fc98f7
Author: Alex Loiko <aleloi@webrtc.org>
Date: Tue Nov 07 14:47:05 2017

Replace left shift with equivalent multiplication.

Issue was found by the NetEq fuzzer.


TBR=kwiberg@webrtc.org

Bug:  chromium:779380 
Change-Id: Ib6a3db78fadc3c7ae11478ca4f695c6d19a2db19
Reviewed-on: https://webrtc-review.googlesource.com/20869
Reviewed-by: Alex Loiko <aleloi@webrtc.org>
Commit-Queue: Alex Loiko <aleloi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20586}
[modify] https://crrev.com/aeb5d88dee9998a26fbe3f76790007a8f2fc98f7/common_audio/vad/vad_filterbank.c

Project Member

Comment 4 by ClusterFuzz, Nov 8 2017

ClusterFuzz has detected this issue as fixed in range 514605:514643.

Detailed report: https://clusterfuzz.com/testcase?key=5971868573237248

Fuzzer: libFuzzer_neteq_signal_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  AllPassFilter
  SplitFilter
  WebRtcVad_CalculateFeatures
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=510532:510572
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=514605:514643

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5971868573237248

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Nov 8 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5971868573237248 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment