New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 779371 link

Starred by 2 users
Status: Fixed
Owner:
jclinton@chromium.org
Closed: Oct 2017
Cc:
█ ssmadan@chromium.org
█ pbe...@chromium.org
yueherngl@chromium.org
nsanders@chromium.org
sjg@chromium.org
shapiroc@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Intercept overlay-snappy drift from baseboard-reef

Project Member Reported by jclinton@chromium.org, Oct 29 2017 
Some changes have been been committed to overlay-snappy instead of the common baseboard-reef. As a result, there's some drift.

When baseboard-reef is used, both legacy and unified builds receive the benefits.

This bug will track moving things to their proper location in baseboard-reef.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/e17b182c0dfbfdf91e39d93fa4b96bc96d602f26

commit e17b182c0dfbfdf91e39d93fa4b96bc96d602f26
Author: Jason D. Clinton <jclinton@chromium.org>
Date: Sun Oct 29 06:04:01 2017

snappy: Move powerd prefs to the correct location

This was added in the wrong place by Quanta. Moving it to the correct
place will make it show up in both snappy and reef-uni builds.

BUG= chromium:779371 
TEST=build and deploy legacy snappy and reef-uni

Change-Id: I227f297a292662fff4ff7f5e8673adb374fa78c8
Reviewed-on: https://chromium-review.googlesource.com/742307
Commit-Ready: Jason Clinton <jclinton@chromium.org>
Tested-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>

[rename] https://crrev.com/e17b182c0dfbfdf91e39d93fa4b96bc96d602f26/baseboard-reef/chromeos-base/chromeos-bsp-baseboard-reef/chromeos-bsp-baseboard-reef-0.0.1-r4.ebuild
[modify] https://crrev.com/e17b182c0dfbfdf91e39d93fa4b96bc96d602f26/overlay-snappy/chromeos-base/chromeos-bsp-snappy/chromeos-bsp-snappy-0.0.1.ebuild
[rename] https://crrev.com/e17b182c0dfbfdf91e39d93fa4b96bc96d602f26/baseboard-reef/chromeos-base/chromeos-bsp-baseboard-reef/files/powerd_prefs/model_specific/snappy/keyboard_backlight_no_als_brightness
[rename] https://crrev.com/e17b182c0dfbfdf91e39d93fa4b96bc96d602f26/overlay-snappy/chromeos-base/chromeos-bsp-snappy/chromeos-bsp-snappy-0.0.1-r14.ebuild
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 29 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-reef-private/+/b782e279a61a19338b78429fcce3255311e3e53e

commit b782e279a61a19338b78429fcce3255311e3e53e
Author: Jason D. Clinton <jclinton@chromium.org>
Date: Sun Oct 29 07:38:18 2017
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 29 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/baseboard-reef-private/+/3466cf4ab371ce0a2f61b90875c3c68cb47ed6a2

commit 3466cf4ab371ce0a2f61b90875c3c68cb47ed6a2
Author: Jason D. Clinton <jclinton@chromium.org>
Date: Sun Oct 29 21:36:27 2017

Comment 4 by jclinton@chromium.org, Oct 30 2017

Status: Fixed (was: Started)
This is complete. Alan and Bigdaddy sound don't work but they also don't work with legacy builds so it seems that nothing about Unibuilds is specific to that. We are fully in sync, now.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 2 2017

Labels: merge-merged-release-R63-10032.B
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/baseboard-reef-private/+/4d94f96fe9ecddf3a48637c1cae18ad392885478

commit 4d94f96fe9ecddf3a48637c1cae18ad392885478
Author: Jason D. Clinton <jclinton@chromium.org>
Date: Sat Dec 02 09:12:57 2017

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 7 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
►

Sign in to add a comment