New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 779338 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 632513
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

'blackbox script' on right button menu is misleading

Reported by davidmax...@gmail.com, Oct 28 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36

Steps to reproduce the problem:
1. open a js file in dev tool eg this page 'wizard.js'
2. find function 'goStep()' and select 'showStep()' call
3. right click
4. select 'blackbox script'

What is the expected behavior?
'showStep()' is blackboxed

What went wrong?
wizard.js is blackboxed

Did this work before? N/A 

Chrome version: 61.0.3163.100  Channel: n/a
OS Version: 10.0
Flash Version: 

I realise (now) that blackboxing is currently a file-level thing, and that function-level blackboxing is being worked on, but it is very misleading to have that option in the menu when a function is selected.
TBH, I imagine I could say the same for a lot (all?) of things on that menu - it looks like they are in the context of the selection, but they're not.
 
Cc: brajkumar@chromium.org
Labels: Needs-Feedback Needs-Milestone
david@ Could you please provide any sample test case file to check this issue from chrome testing team end?

Thanks!
I think I did that already...using this page as an example.
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 30 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "brajkumar@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: kozy@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 5 by kozy@chromium.org, Dec 5 2017

Mergedinto: 632513
Status: Duplicate (was: Assigned)
Thanks for your report!

Context menu said "Blackbox script". We can be better in naming here.
We are not going to support function level blackboxing in near future.

As work around you can evaluate your function using eval with dedicated sourceURL and use this source url to blackbox it.
I'm not really after a work around, since the problem is simply a matter of learning/comprehension - this issue isn't about having a function level blackboxing facility, but is about the menu being misleading. As such:

> We can be better in naming here.

about sums it up.

(Having said that, I guess the comments on function level blackboxing might help people who arrive here via such a search, so no problem)

Sign in to add a comment