New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 779337 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference in viz::TestLayerTreeFrameSink::RequestCopyOfOutput

Project Member Reported by ClusterFuzz, Oct 28 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6462481588551680

Fuzzer: inferno_layout_test_unmodified
Job Type: windows_syzyasan_content_shell
Platform Id: windows

Crash Type: Null-dereference
Crash Address: 0x000001d3
Crash State:
  viz::TestLayerTreeFrameSink::RequestCopyOfOutput
  content::CopyRequestSwapPromise::WillSwap
  cc::LayerTreeImpl::FinishSwapPromises
  
Memory Tool: SYZYASAN

Regressed: https://clusterfuzz.com/revisions?job=windows_syzyasan_content_shell&range=512297:512363

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6462481588551680

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Cc: msrchandra@chromium.org pnangunoori@chromium.org
Labels: M-64 Test-Predator-Wrong
Owner: smcgruer@chromium.org
Status: Assigned (was: Untriaged)
Using the provided regression range assigning to the possible suspect as per the change made for the file, “layer_tree_impl.cc”
Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/cede03e95214eeba962a300f5a5fe47f3bfd3e45

@smcgruer -- Could you please look into this issue, kindly reassign if it has nothing to do with your changes.

Cc: smcgruer@chromium.org
Owner: danakj@chromium.org
I doubt my change caused this; I was simply changing a method to be const.

Given that viz/ is involved, I would suspect https://chromium.googlesource.com/chromium/src/+/33bb6c6ac24c6054a6f36f31a0fc3234fbc93c07 from danajk@ - Dana could this be your change?
Project Member

Comment 3 by ClusterFuzz, Oct 31 2017

Components: Internals>Compositing
Labels: Test-Predator-AutoComponents
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 4 by ClusterFuzz, Oct 31 2017

ClusterFuzz has detected this issue as fixed in range 512594:512673.

Detailed report: https://clusterfuzz.com/testcase?key=6462481588551680

Fuzzer: inferno_layout_test_unmodified
Job Type: windows_syzyasan_content_shell
Platform Id: windows

Crash Type: Null-dereference
Crash Address: 0x000001d3
Crash State:
  viz::TestLayerTreeFrameSink::RequestCopyOfOutput
  content::CopyRequestSwapPromise::WillSwap
  cc::LayerTreeImpl::FinishSwapPromises
  
Memory Tool: SYZYASAN

Regressed: https://clusterfuzz.com/revisions?job=windows_syzyasan_content_shell&range=512297:512363
Fixed: https://clusterfuzz.com/revisions?job=windows_syzyasan_content_shell&range=512594:512673

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6462481588551680

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Oct 31 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6462481588551680 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Dana - looks like (probably) this was fixed by the revert of your patch? https://chromium.googlesource.com/chromium/src/+/e7d9e173258d7a04965d1bdd62e64e0ff70c69cb

If so there is no further action here, but hopefully this will be a useful test for when you re-land :)
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components

Sign in to add a comment