New issue
Advanced search Search tips

Issue 779321 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: pos_ == box_size_ in box_reader.cc

Project Member Reported by ClusterFuzz, Oct 28 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4559812687036416

Fuzzer: libFuzzer_mediasource_MP4_FLAC_pipeline_integration_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  pos_ == box_size_ in box_reader.cc
  media::mp4::BoxReader::ScanChildren
  media::mp4::AudioSampleEntry::Parse
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=512266:512309

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4559812687036416

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Cc: kkaluri@chromium.org
Components: Blink>Media
Labels: M-64 Test-Predator-Wrong
Owner: sande...@chromium.org
Status: Assigned (was: Untriaged)
Predator could not provide any possible suspects.
Using the CL search for the file, “box_reader.cc” assigning to concern owner.

Suspecting Commit# https://chromium.googlesource.com/chromium/src/+/f7b33b92746f6d3758c66048ea3106283279668b

sandersd@ -- Could you please look into this issue, kindly reassign if it has nothing to do with your changes.


Thank You...
Project Member

Comment 2 by ClusterFuzz, Oct 31 2017

Components: Internals>Media
Labels: Test-Predator-AutoComponents
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b28187dab3fec3bfe98a366ea5d07c1d9b110b4

commit 4b28187dab3fec3bfe98a366ea5d07c1d9b110b4
Author: Dan Sanders <sandersd@chromium.org>
Date: Tue Oct 31 23:35:50 2017

[media] BoxReader: Cap |buf_size_| to |box_size_|.

Before this change, BoxReader could read syntax elements outside of a
box in cases where the MP4 was invalid. This isn't a security concern,
since the reads were still bounded by the buffer size, but it did make
it hard to interpret the later failures.

This CL shrinks |buf_size_| to match |box_size_| when the box size is
read. OOB reads will now result in Parse failures immediately.

Bug:  779321 
Change-Id: I54be6ba3815d1502233b5e95d099ce9d9a54b3cc
Reviewed-on: https://chromium-review.googlesource.com/747080
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513000}
[modify] https://crrev.com/4b28187dab3fec3bfe98a366ea5d07c1d9b110b4/media/formats/mp4/box_reader.cc
[modify] https://crrev.com/4b28187dab3fec3bfe98a366ea5d07c1d9b110b4/media/formats/mp4/box_reader.h
[modify] https://crrev.com/4b28187dab3fec3bfe98a366ea5d07c1d9b110b4/media/formats/mp4/box_reader_unittest.cc

Project Member

Comment 4 by ClusterFuzz, Nov 1 2017

ClusterFuzz has detected this issue as fixed in range 512996:513028.

Detailed report: https://clusterfuzz.com/testcase?key=4559812687036416

Fuzzer: libFuzzer_mediasource_MP4_FLAC_pipeline_integration_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  pos_ == box_size_ in box_reader.cc
  media::mp4::BoxReader::ScanChildren
  media::mp4::AudioSampleEntry::Parse
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=512266:512309
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=512996:513028

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4559812687036416

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Nov 1 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4559812687036416 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components

Sign in to add a comment